Source/modules/push_messaging/PushManager.idl - Issue 658723003: Blink implementation of PushManager#hasPermission()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushManager.idl

Issue 658723003: Blink implementation of PushManager#hasPermission() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename enum to a more understandable name Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/push_messaging/PushManager.cpp ('K') | « Source/modules/push_messaging/PushManager.cpp ('k') | Source/modules/push_messaging/PushPermissionCallback.h » ('j') | Source/modules/push_messaging/PushPermissionCallback.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushManager.idl

diff --git a/Source/modules/push_messaging/PushManager.idl b/Source/modules/push_messaging/PushManager.idl

index 4346304f2dd9b9587ee20ff38a6040123f267944..30ba113931bfaaf30b82938e2ab282cb23369590 100644

--- a/Source/modules/push_messaging/PushManager.idl

+++ b/Source/modules/push_messaging/PushManager.idl

@@ -8,4 +8,5 @@

GarbageCollected,

] interface PushManager {

[CallWith=ScriptState, ImplementedAs=registerPushMessaging] Promise register(DOMString senderId);

+ [CallWith=ScriptState] Promise permissionStatus();

mlamouri (slow - plz ping) 2014/10/17 09:22:01 Shouldn't that be called hasPermission()?

Miguel Garcia 2014/10/20 09:58:10 Indeed, I must have confused things with the resul

};