Source/modules/push_messaging/PushManager.idl - Issue 658723003: Blink implementation of PushManager#hasPermission()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/push_messaging/PushManager.idl

Issue 658723003: Blink implementation of PushManager#hasPermission() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename enum to a more understandable name Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/push_messaging/PushManager.cpp ('K') | « Source/modules/push_messaging/PushManager.cpp ('k') | Source/modules/push_messaging/PushPermissionCallback.h » ('j') | Source/modules/push_messaging/PushPermissionCallback.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 NoInterfaceObject,	6 NoInterfaceObject,

7 RuntimeEnabled=PushMessaging,	7 RuntimeEnabled=PushMessaging,

8 GarbageCollected,	8 GarbageCollected,

9 ] interface PushManager {	9 ] interface PushManager {

10 [CallWith=ScriptState, ImplementedAs=registerPushMessaging] Promise register (DOMString senderId);	10 [CallWith=ScriptState, ImplementedAs=registerPushMessaging] Promise register (DOMString senderId);

	11 [CallWith=ScriptState] Promise permissionStatus();
	mlamouri (slow - plz ping) 2014/10/17 09:22:01 Shouldn't that be called hasPermission()? Shouldn't that be called hasPermission()? Miguel Garcia 2014/10/20 09:58:10 Indeed, I must have confused things with the resul Show quoted text On 2014/10/17 09:22:01, Mounir Lamouri wrote: > Shouldn't that be called hasPermission()? Indeed, I must have confused things with the result type when reading the spec.
11 };	12 };

OLD	NEW