Issue 658513004: Fix recreate_skps?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 658513004: Fix recreate_skps? (Closed)

Created:
6 years, 2 months ago by borenet

Modified:
6 years, 2 months ago

Reviewers:
rmistry

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Fix recreate_skps? run_measurement was removed in https://codereview.chromium.org/655563007. Based on the comments, I think the right thing to do is replace it with run_benchmark. Hopefully this fixes the bot. BUG=skia: TBR=rmistry NOTRY=true Committed: https://skia.googlesource.com/skia/+/783991585be67da3286680d850a99c5410885965

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	tools/skp/webpages_playback.py	View		4 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658513004/1

6 years, 2 months ago (2014-10-17 19:15:34 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 19:15:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 783991585be67da3286680d850a99c5410885965