telemetry: remove run_measurment script.

telemetry: remove run_measurment script.

R=dtu@chromium.org,nednguyen@chromium.org,tonyg@chromium.org
BUG=423563
Committed: https://crrev.com/82aec9c0dc818229baffb65eca30465894b34312
Cr-Commit-Position: refs/heads/master@{#299968}

[ernstm, 2014-10-15 00:27:39]

ernstm@chromium.org changed reviewers:
+ nednguyen@google.com
- nednguyen@chromium.org

[ernstm, 2014-10-15 00:27:39]

Moving this to a separate CL. Can someone help with scraping the bots, etc., for
references to run_measurement?

[tonyg, 2014-10-15 00:34:20]

On 2014/10/15 00:27:39, ernstm wrote:
> Moving this to a separate CL. Can someone help with scraping the bots, etc.,
for
> references to run_measurement?

I'm quite sure that the chromium.perf waterfall doesn't reference it, but not
sure about others. I'd recommend first cleaning up these references:
https://code.google.com/p/chromium/codesearch#search/&q=run_measurement&sq=pa...

Then landing this patch once at least the codesearchable things are gone.

lgtm in advance for whenever you're feeling brave :)

[nednguyen, 2014-10-15 00:41:08]

nednguyen@google.com changed reviewers:
+ achuith@chromium.org, kbr@chromium.org, qyearsley@chromium.org

[dtu, 2014-10-15 00:49:19]

Also remove run_multipage_benchmarks! I can't believe that's still around.

[ernstm, 2014-10-16 00:31:22]

On 2014/10/15 00:34:20, tonyg wrote:
> On 2014/10/15 00:27:39, ernstm wrote:
> > Moving this to a separate CL. Can someone help with scraping the bots, etc.,
> for
> > references to run_measurement?
> 
> I'm quite sure that the chromium.perf waterfall doesn't reference it, but not
> sure about others. I'd recommend first cleaning up these references:
>
https://code.google.com/p/chromium/codesearch#search/&q=run_measurement&sq=pa...
> 
> Then landing this patch once at least the codesearchable things are gone.
> 
> lgtm in advance for whenever you're feeling brave :)

Removed all references to run_measurement from Chrome and also removed
run_multipage_benchmarks.

Need to remove reference in a comment in Blink
(src/third_party/WebKit/Tools/run-perf-test.cfg) in a separate patch. Probably
best to replace run-perf-test.cfg by the latest version from src/tools.

[Ken Russell (switch to Gerrit), 2014-10-16 03:47:10]

chrome/telemetry.isolate LGTM FWIW

[ernstm, 2014-10-16 17:05:31]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-10-16 17:07:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/655563007/20001

[commit-bot: I haz the power, 2014-10-16 17:21:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-16 17:21:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ernstm, 2014-10-16 17:57:46]

ernstm@chromium.org changed reviewers:
+ sky@chromium.org

[ernstm, 2014-10-16 17:57:47]

Scott, we need an owners review for chrome/telemetry.isolate. Can you please
take a look?

[sky, 2014-10-16 19:51:49]

LGTM

[ernstm, 2014-10-16 20:22:50]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-10-16 20:23:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/655563007/20001

[commit-bot: I haz the power, 2014-10-16 20:28:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-16 20:29:13]

Patchset 2 (id:??) landed as
https://crrev.com/82aec9c0dc818229baffb65eca30465894b34312
Cr-Commit-Position: refs/heads/master@{#299968}

[Peter Kasting, 2014-10-17 01:01:21]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2014-10-17 01:01:21]

I think this may have broken the perf trybots (symptom: no "HTML Results" link
in the output for runs like https://codereview.chromium.org/653293003/ ).

I sent email about this.

[dtu, 2014-10-17 02:05:33]

Sorry for the late notice - there's no way this will stick. ChromeOS is still
using "run_measurement --print-bootstrap-deps-cros"
We need to convert the code to use "run_benchmark deps"

[ernstm, 2014-10-17 04:50:49]

On 2014/10/17 02:05:33, dtu wrote:
> Sorry for the late notice - there's no way this will stick. ChromeOS is still
> using "run_measurement --print-bootstrap-deps-cros"
> We need to convert the code to use "run_benchmark deps"

Where and how is ChromeOS using this?

[dtu, 2014-10-17 06:44:17]

On 2014/10/17 04:50:49, ernstm wrote:
> On 2014/10/17 02:05:33, dtu wrote:
> > Sorry for the late notice - there's no way this will stick. ChromeOS is
still
> > using "run_measurement --print-bootstrap-deps-cros"
> > We need to convert the code to use "run_benchmark deps"
> 
> Where and how is ChromeOS using this?

ChromeOS uses it to determine which files to copy to the device when creating a
test image.
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ma...
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ma...

[rnephew (Reviews Here), 2014-10-17 15:26:24]

The clank perf bots are running a test using run_measurement, are these doing
the same thing if so I'll just set it to run with run_benchmark.

tools/perf/run_measurement -v --browser=android-chrome
--extra-browser-args=--spdy-proxy-origin --show-stdout --output-format=buildbot
memory_multi_tab blank_page 
tools/perf/run_benchmark -v --browser=android-chrome
--extra-browser-args=--spdy-proxy-origin --show-stdout --output-format=buildbot
memory_multi_tab blank_page

[tonyg, 2014-10-17 16:23:26]

On 2014/10/17 15:26:24, rnephew1 wrote:
> The clank perf bots are running a test using run_measurement, are these doing
> the same thing if so I'll just set it to run with run_benchmark.
> 
> tools/perf/run_measurement -v --browser=android-chrome
> --extra-browser-args=--spdy-proxy-origin --show-stdout
--output-format=buildbot
> memory_multi_tab blank_page 
> tools/perf/run_benchmark -v --browser=android-chrome
> --extra-browser-args=--spdy-proxy-origin --show-stdout
--output-format=buildbot
> memory_multi_tab blank_page

That looks like the right fix for now. We should really figure out a plan for
moving away from hardcoded commands on bots though.