Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 658503003: Enables specifying mojo url mapping on command line (Closed)

Created:
6 years, 2 months ago by sky
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enables specifying mojo url mapping on command line This makes it possible to redirect something like mojo:view_manager to mojo:view_manager-test. BUG=none TEST=none R=davemoore@chromium.org Committed: https://crrev.com/67561765c45fb5126ebdd75dafd2c00e450d9f87 Cr-Commit-Position: refs/heads/master@{#299700}

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 4

Patch Set 3 : fix windows #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -30 lines) Patch
M mojo/mojo.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 2 chunks +1 line, -10 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 1 3 chunks +41 lines, -14 lines 0 comments Download
M mojo/shell/mojo_url_resolver.h View 3 chunks +10 lines, -1 line 0 comments Download
M mojo/shell/mojo_url_resolver.cc View 1 2 2 chunks +18 lines, -5 lines 0 comments Download
A mojo/shell/mojo_url_resolver_unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M mojo/shell/switches.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
sky
https://codereview.chromium.org/658503003/diff/20001/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc File mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc (left): https://codereview.chromium.org/658503003/diff/20001/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc#oldcode96 mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc:96: // TODO(beng): Come up with a better way of ...
6 years, 2 months ago (2014-10-14 22:53:03 UTC) #1
DaveMoore
lgtm
6 years, 2 months ago (2014-10-15 00:08:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658503003/20001
6 years, 2 months ago (2014-10-15 00:12:10 UTC) #4
Aaron Boodman
https://codereview.chromium.org/658503003/diff/20001/mojo/shell/desktop/mojo_main.cc File mojo/shell/desktop/mojo_main.cc (right): https://codereview.chromium.org/658503003/diff/20001/mojo/shell/desktop/mojo_main.cc#newcode98 mojo/shell/desktop/mojo_main.cc:98: for (const StringPair& pair : pairs) { Can't you ...
6 years, 2 months ago (2014-10-15 00:34:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/58579)
6 years, 2 months ago (2014-10-15 01:19:55 UTC) #8
sky
https://codereview.chromium.org/658503003/diff/20001/mojo/shell/desktop/mojo_main.cc File mojo/shell/desktop/mojo_main.cc (right): https://codereview.chromium.org/658503003/diff/20001/mojo/shell/desktop/mojo_main.cc#newcode98 mojo/shell/desktop/mojo_main.cc:98: for (const StringPair& pair : pairs) { On 2014/10/15 ...
6 years, 2 months ago (2014-10-15 03:14:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658503003/40001
6 years, 2 months ago (2014-10-15 14:37:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/79330) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/68906) win_gpu ...
6 years, 2 months ago (2014-10-15 14:39:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658503003/60001
6 years, 2 months ago (2014-10-15 15:42:36 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-15 17:10:40 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 17:11:33 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/67561765c45fb5126ebdd75dafd2c00e450d9f87
Cr-Commit-Position: refs/heads/master@{#299700}

Powered by Google App Engine
This is Rietveld 408576698