Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: components/constrained_window.gypi

Issue 658383003: Componentize Constrained Window Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: gn Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/constrained_window.gypi
diff --git a/components/search.gypi b/components/constrained_window.gypi
similarity index 53%
copy from components/search.gypi
copy to components/constrained_window.gypi
index 8cb0fe71e0ccc4c3ede8817c284faf90d5d4e623..d9094361381d686bed6fc18c69a50f349fb141d7 100644
--- a/components/search.gypi
+++ b/components/constrained_window.gypi
@@ -1,23 +1,22 @@
# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-
{
'targets': [
{
- 'target_name': 'search',
+ 'target_name': 'constrained_window',
'type': 'static_library',
'dependencies': [
- '../base/base.gyp:base'
+ '<(DEPTH)/components/components.gyp:web_modal',
+ '<(DEPTH)/ui/views/views.gyp:views',
+ '<(DEPTH)/skia/skia.gyp:skia',
msw 2014/10/22 21:32:43 Skia doesn't appear to be used directly, is there
oshima 2014/10/22 22:39:09 This is necessary for skia header included indirec
msw 2014/10/23 18:49:05 Acknowledged.
],
'include_dirs': [
'..',
],
'sources': [
- 'search/search.cc',
- 'search/search.h',
- 'search/search_switches.cc',
- 'search/search_switches.h',
+ 'constrained_window/constrained_window_views.cc',
msw 2014/10/22 21:32:43 Shouldn't this list include constrained_window_vie
oshima 2014/10/22 22:39:09 Done.
+ 'constranied_window/constrained_window_views.h',
],
},
],

Powered by Google App Engine
This is Rietveld 408576698