components/constrained_window.gypi - Issue 658383003: Componentize Constrained Window Views

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/constrained_window.gypi

Issue 658383003: Componentize Constrained Window Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: gn Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4

5 {	4 {

6 'targets': [	5 'targets': [

7 {	6 {

8 'target_name': 'search',	7 'target_name': 'constrained_window',

9 'type': 'static_library',	8 'type': 'static_library',

10 'dependencies': [	9 'dependencies': [

11 '../base/base.gyp:base'	10 '<(DEPTH)/components/components.gyp:web_modal',

	11 '<(DEPTH)/ui/views/views.gyp:views',

	12 '<(DEPTH)/skia/skia.gyp:skia',
	msw 2014/10/22 21:32:43 Skia doesn't appear to be used directly, is there Skia doesn't appear to be used directly, is there a transitive dependency through views, and if so, would removing this explicit dependency entry be okay? oshima 2014/10/22 22:39:09 This is necessary for skia header included indirec Show quoted text On 2014/10/22 21:32:43, msw wrote: > Skia doesn't appear to be used directly, is there a transitive dependency > through views, and if so, would removing this explicit dependency entry be okay? This is necessary for skia header included indirectly. msw 2014/10/23 18:49:05 Acknowledged. Show quoted text On 2014/10/22 22:39:09, oshima wrote: > On 2014/10/22 21:32:43, msw wrote: > > Skia doesn't appear to be used directly, is there a transitive dependency > > through views, and if so, would removing this explicit dependency entry be > okay? > > This is necessary for skia header included indirectly. Acknowledged.
12 ],	13 ],

13 'include_dirs': [	14 'include_dirs': [

14 '..',	15 '..',

15 ],	16 ],

16 'sources': [	17 'sources': [

17 'search/search.cc',	18 'constrained_window/constrained_window_views.cc',
	msw 2014/10/22 21:32:43 Shouldn't this list include constrained_window_vie Shouldn't this list include constrained_window_views_client.h? oshima 2014/10/22 22:39:09 Done. Show quoted text On 2014/10/22 21:32:43, msw wrote: > Shouldn't this list include constrained_window_views_client.h? Done.
18 'search/search.h',	19 'constranied_window/constrained_window_views.h',

19 'search/search_switches.cc',

20 'search/search_switches.h',

21 ],	20 ],

22 },	21 },

23 ],	22 ],

24 }	23 }

OLD	NEW

« components/OWNERS ('K') | « components/components_tests.gyp ('k') | components/constrained_window/BUILD.gn » ('j') | components/constrained_window/BUILD.gn » ('J')