Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 658293004: Revert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe (Closed)

Created:
6 years, 2 months ago by rmistry
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe (patchset #5 id:80001 of https://codereview.chromium.org/613673005/) Reason for revert: Trying to fix DEPS roll failure: https://codereview.chromium.org/660113002/ Link to failing builds: http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29578 http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/29354 Original issue's description: > Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe > > BUG=skia:2947 > > Committed: https://skia.googlesource.com/skia/+/687732fe046c9cfec940f2d7f661cd97651d10a8 TBR=junov@chromium.org,reed@google.com,bsalomon@chromium.org,piotaixr@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2947 Committed: https://skia.googlesource.com/skia/+/6fedd3a4e6f97f4e28946091e204cd8aedbd0b70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -169 lines) Patch
M include/utils/SkDeferredCanvas.h View 2 chunks +3 lines, -7 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 3 chunks +3 lines, -39 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 6 chunks +6 lines, -88 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmistry
Created Revert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe
6 years, 2 months ago (2014-10-17 13:18:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658293004/1
6 years, 2 months ago (2014-10-17 13:19:18 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 13:19:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 6fedd3a4e6f97f4e28946091e204cd8aedbd0b70

Powered by Google App Engine
This is Rietveld 408576698