[DevTools] Added browser protocol to handler generator

[DevTools] Added browser protocol to handler generator

BUG=405566
Committed: https://crrev.com/5323241303055424caca721c48306aae8d10df35
Cr-Commit-Position: refs/heads/master@{#303632}

[vkuzkokov, 2014-10-16 15:17:42]

vkuzkokov@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2014-10-17 13:11:28]

Does this compiler with 2 files named "tethering_handler"?

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
File content/browser/devtools/protocol/devtools_protocol_handler_generator.py
(right):

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:423:
${dict_var}->Set("${proto_param}", ${var_name}.release());
Should this go to previous patch?

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:503:
mapping["domain"] = Uncamelcase(domain_name)
ditto

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:618:
domain_map["domain"] = Uncamelcase(json_domain["domain"])
ditto

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
File content/browser/devtools/protocol/system_info_handler.cc (right):

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
content/browser/devtools/protocol/system_info_handler.cc:7: #include
"base/strings/utf_string_conversions.h"
Includes are unnecessary.

[vkuzkokov, 2014-10-17 15:46:18]

Patchset #2 (id:20001) has been deleted

[vkuzkokov, 2014-10-17 15:53:17]

Changes in content/browser/devtools/devtools_http_handler_impl.cc are omitted
until 635733003 lands.

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
File content/browser/devtools/protocol/devtools_protocol_handler_generator.py
(right):

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:423:
${dict_var}->Set("${proto_param}", ${var_name}.release());
On 2014/10/17 13:11:28, dgozman wrote:
> Should this go to previous patch?

Done.

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:503:
mapping["domain"] = Uncamelcase(domain_name)
On 2014/10/17 13:11:28, dgozman wrote:
> ditto

Done.

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:618:
domain_map["domain"] = Uncamelcase(json_domain["domain"])
On 2014/10/17 13:11:28, dgozman wrote:
> ditto

Done.

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
File content/browser/devtools/protocol/system_info_handler.cc (right):

https://codereview.chromium.org/658163003/diff/1/content/browser/devtools/pro...
content/browser/devtools/protocol/system_info_handler.cc:7: #include
"base/strings/utf_string_conversions.h"
On 2014/10/17 13:11:28, dgozman wrote:
> Includes are unnecessary.

Done.

[dgozman, 2014-10-17 17:10:24]

lgtm

[vkuzkokov, 2014-10-23 17:07:38]

Patchset #4 (id:80001) has been deleted

[vkuzkokov, 2014-10-23 17:18:20]

Patchset #3 (id:60001) has been deleted

[vkuzkokov, 2014-10-23 17:18:30]

Patchset #3 (id:100001) has been deleted

[vkuzkokov, 2014-10-23 17:28:57]

Patchset #3 (id:120001) has been deleted

[dgozman, 2014-10-28 10:08:16]

I think you should rebase this on ToT and land before typebuilder patch.

[vkuzkokov, 2014-10-28 11:36:59]

On 2014/10/28 10:08:16, dgozman wrote:
> I think you should rebase this on ToT and land before typebuilder patch.

It's only based on typebuilder patch because it's required for GPUInfo: object
without list of prepertie translates to base::DictionaryValue* which doesn't
translate well to copyable generated structs.

[vkuzkokov, 2014-11-11 08:59:41]

Patchset #7 (id:220001) has been deleted

[dgozman, 2014-11-11 10:38:47]

still lgtm

https://codereview.chromium.org/658163003/diff/200001/content/browser/devtool...
File content/browser/devtools/protocol/devtools_protocol_handler_generator.py
(right):

https://codereview.chromium.org/658163003/diff/200001/content/browser/devtool...
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:23: // 
third_party/WebKit/Source/devtools/protocol.json
nit: list browser protocol here.

[vkuzkokov, 2014-11-11 11:06:00]

https://codereview.chromium.org/658163003/diff/200001/content/browser/devtool...
File content/browser/devtools/protocol/devtools_protocol_handler_generator.py
(right):

https://codereview.chromium.org/658163003/diff/200001/content/browser/devtool...
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:23: // 
third_party/WebKit/Source/devtools/protocol.json
On 2014/11/11 10:38:46, dgozman wrote:
> nit: list browser protocol here.

Done.

[vkuzkokov, 2014-11-11 11:06:08]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-11-11 11:06:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/658163003/240001

[commit-bot: I haz the power, 2014-11-11 11:09:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-11 11:09:15]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[vkuzkokov, 2014-11-11 11:22:02]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-11-11 11:22:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/658163003/260001

[commit-bot: I haz the power, 2014-11-11 11:26:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-11 11:26:43]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vkuzkokov, 2014-11-11 11:36:53]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-11-11 11:37:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/658163003/280001

[commit-bot: I haz the power, 2014-11-11 12:56:02]

Committed patchset #9 (id:280001)

[commit-bot: I haz the power, 2014-11-11 12:56:44]

Patchset 9 (id:??) landed as
https://crrev.com/5323241303055424caca721c48306aae8d10df35
Cr-Commit-Position: refs/heads/master@{#303632}