Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6235)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 658163003: [DevTools] Added browser protocol to handler generator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@singleUse
Patch Set: GN fix Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_impl.cc
diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc
index e7b7fb9b99e68f17eff500742b76addccf88e3e3..6ee6eaafe9586e91899e7aaf585da51eadc0baa9 100644
--- a/content/browser/devtools/devtools_http_handler_impl.cc
+++ b/content/browser/devtools/devtools_http_handler_impl.cc
@@ -22,8 +22,8 @@
#include "content/browser/devtools/devtools_protocol_constants.h"
#include "content/browser/devtools/devtools_system_info_handler.h"
#include "content/browser/devtools/protocol/devtools_protocol_handler_impl.h"
+#include "content/browser/devtools/protocol/tethering_handler.h"
#include "content/browser/devtools/protocol/tracing_handler.h"
-#include "content/browser/devtools/tethering_handler.h"
#include "content/common/devtools_messages.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/devtools_agent_host.h"
@@ -156,15 +156,19 @@ class DevToolsHttpHandlerImpl::BrowserTarget {
public:
BrowserTarget(base::MessageLoop* message_loop,
net::HttpServer* server,
+ DevToolsHttpHandlerDelegate* delegate,
int connection_id)
: message_loop_(message_loop),
server_(server),
connection_id_(connection_id),
+ tethering_handler_(new devtools::tethering::TetheringHandler(
+ delegate, message_loop->message_loop_proxy())),
tracing_handler_(new devtools::tracing::TracingHandler(
devtools::tracing::TracingHandler::Browser)),
protocol_handler_(new DevToolsProtocolHandlerImpl()) {
protocol_handler_->SetNotifier(
base::Bind(&BrowserTarget::Respond, base::Unretained(this)));
+ protocol_handler_->SetTetheringHandler(tethering_handler_.get());
protocol_handler_->SetTracingHandler(tracing_handler_.get());
}
@@ -220,6 +224,7 @@ class DevToolsHttpHandlerImpl::BrowserTarget {
base::MessageLoop* const message_loop_;
net::HttpServer* const server_;
const int connection_id_;
+ scoped_ptr<devtools::tethering::TetheringHandler> tethering_handler_;
scoped_ptr<devtools::tracing::TracingHandler> tracing_handler_;
scoped_ptr<DevToolsProtocolHandlerImpl> protocol_handler_;
std::vector<DevToolsProtocol::Handler*> handlers_;
@@ -701,9 +706,7 @@ void DevToolsHttpHandlerImpl::OnWebSocketRequestUI(
size_t browser_pos = request.path.find(browser_prefix);
if (browser_pos == 0) {
BrowserTarget* browser_target = new BrowserTarget(
- thread_->message_loop(), server_.get(), connection_id);
- browser_target->RegisterHandler(
- new TetheringHandler(delegate_.get(), thread_->message_loop_proxy()));
+ thread_->message_loop(), server_.get(), delegate_.get(), connection_id);
browser_target->RegisterHandler(
new DevToolsSystemInfoHandler());
browser_targets_[connection_id] = browser_target;
« no previous file with comments | « content/browser/devtools/devtools.gyp ('k') | content/browser/devtools/protocol/devtools_protocol_handler_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698