Fix the issue where checking a form for :valid/:invalid would trigger invalid events for its elemen…

Source/core/html/HTMLFormControlElement.h

Index: Source/core/html/HTMLFormControlElement.h
diff --git a/Source/core/html/HTMLFormControlElement.h b/Source/core/html/HTMLFormControlElement.h
index 4904ed4277696ea1cf8d3a5303831c933a472a73..58dea85192b0ed484ff1c79c1b759a8b701eae99 100644
--- a/Source/core/html/HTMLFormControlElement.h
+++ b/Source/core/html/HTMLFormControlElement.h
@@ -85,11 +85,11 @@ public:
     virtual void setActivatedSubmit(bool) { }
 
     virtual bool willValidate() const override;
-    virtual bool matchesValidityPseudoClasses() const override;
 
     void updateVisibleValidationMessage();
     void hideVisibleValidationMessage();
-    bool checkValidity(WillBeHeapVector<RefPtrWillBeMember<FormAssociatedElement> >* unhandledInvalidControls = 0);
+    enum DispatchInvalidEvent { DispatchInvalidEventUnknown, DispatchInvalidEventEnabled, DispatchInvalidEventDisabled };

[keishi, 2014/10/17 05:46:12]

We're not switching a enabled/disabled state so I think the names would be
better if we follow TextFieldEventBehavior's and name it something like
DispatchInvalidEvent and DispatchNoEvent. I don't think we need the Unknown
entry.

[Bartek Nowierski, 2014/10/17 06:17:59]

Your suggestion created a clash with DispatcNoEvent from TextFieldEventBehavior.
I resolved it by making longer names. Let me know if you like it.

+    bool checkValidity(WillBeHeapVector<RefPtrWillBeMember<FormAssociatedElement> >* unhandledInvalidControls = 0, DispatchInvalidEvent = DispatchInvalidEventEnabled);
     // This must be called when a validation constraint or control value is changed.
     void setNeedsValidityCheck();
     virtual void setCustomValidity(const String&) override final;
@@ -157,6 +157,7 @@ private:
 
     virtual bool isDefaultButtonForForm() const override final;
     virtual bool isValidElement() override final;
+    virtual bool matchesValidityPseudoClasses() const override final;
     void updateAncestorDisabledState() const;
 
     bool isValidationMessageVisible() const;