Fix the issue where checking a form for :valid/:invalid would trigger invalid events for its elemen…

Source/core/html/HTMLFormControlElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 67 matching lines @@
     // Return true for a successful control (see HTML4-17.13.2).
     virtual bool appendFormData(FormDataList&, bool) override { return false; }
     virtual String resultForDialogSubmit();
 
     virtual bool canBeSuccessfulSubmitButton() const { return false; }
     bool isSuccessfulSubmitButton() const;
     virtual bool isActivatedSubmit() const { return false; }
     virtual void setActivatedSubmit(bool) { }
 
     virtual bool willValidate() const override;
-    virtual bool matchesValidityPseudoClasses() const override;
 
     void updateVisibleValidationMessage();
     void hideVisibleValidationMessage();
-    bool checkValidity(WillBeHeapVector<RefPtrWillBeMember<FormAssociatedElement> >* unhandledInvalidControls = 0);
+    enum DispatchInvalidEvent { DispatchInvalidEventUnknown, DispatchInvalidEventEnabled, DispatchInvalidEventDisabled };

[keishi, 2014/10/17 05:46:12]

We're not switching a enabled/disabled state so I think the names would be
better if we follow TextFieldEventBehavior's and name it something like
DispatchInvalidEvent and DispatchNoEvent. I don't think we need the Unknown
entry.

[Bartek Nowierski, 2014/10/17 06:17:59]

Your suggestion created a clash with DispatcNoEvent from TextFieldEventBehavior.
I resolved it by making longer names. Let me know if you like it.

+    bool checkValidity(WillBeHeapVector<RefPtrWillBeMember<FormAssociatedElement> >* unhandledInvalidControls = 0, DispatchInvalidEvent = DispatchInvalidEventEnabled);
     // This must be called when a validation constraint or control value is changed.
     void setNeedsValidityCheck();
     virtual void setCustomValidity(const String&) override final;
     void findCustomValidationMessageTextDirection(const String& message, TextDirection &messageDir, String& subMessage, TextDirection& subMessageDir);
 
     bool isReadOnly() const { return m_isReadOnly; }
     bool isDisabledOrReadOnly() const { return isDisabledFormControl() || m_isReadOnly; }
 
     bool isAutofocusable() const;
 
@@ skipping 47 matching lines @@
     virtual void derefFormAssociatedElement() override final { deref(); }
 #endif
 
     virtual bool isFormControlElement() const override final { return true; }
     virtual bool alwaysCreateUserAgentShadowRoot() const override { return true; }
 
     virtual short tabIndex() const override final;
 
     virtual bool isDefaultButtonForForm() const override final;
     virtual bool isValidElement() override final;
+    virtual bool matchesValidityPseudoClasses() const override final;
     void updateAncestorDisabledState() const;
 
     bool isValidationMessageVisible() const;
     ValidationMessageClient* validationMessageClient() const;
 
     // Requests validity recalc for the form owner, if one exists.
     void formOwnerSetNeedsValidityCheck();
 
     bool m_disabled : 1;
     bool m_isAutofilled : 1;
@@ skipping 24 matching lines @@
 {
     return element.isFormControlElement();
 }
 
 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement);
 DEFINE_TYPE_CASTS(HTMLFormControlElement, FormAssociatedElement, control, control->isFormControlElement(), control.isFormControlElement());
 
 } // namespace
 
 #endif