Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 6580056: Make global NaN, Infinity and undefined read only. (Closed)

Created:
9 years, 10 months ago by Martin Maly
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make global NaN, Infinity and undefined read only. Change test expectation files where tests now pass, or newly fail. BUG= TEST=sputnik, es5conform, mozilla

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M src/v8natives.js View 1 chunk +4 lines, -3 lines 0 comments Download
M test/es5conform/es5conform.status View 1 chunk +0 lines, -15 lines 1 comment Download
M test/mjsunit/undeletable-functions.js View 1 chunk +1 line, -1 line 0 comments Download
M test/sputnik/sputnik.status View 1 chunk +18 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Martin Maly
This came up as part of strict mode work. Firefox and Safari already have NaN, ...
9 years, 10 months ago (2011-02-25 02:26:03 UTC) #1
Lasse Reichstein
9 years, 10 months ago (2011-02-25 06:27:43 UTC) #2
LGTM

http://codereview.chromium.org/6580056/diff/1/test/sputnik/sputnik.status
File test/sputnik/sputnik.status (right):

http://codereview.chromium.org/6580056/diff/1/test/sputnik/sputnik.status#new...
test/sputnik/sputnik.status:190: # Should V8 throw or ignore the assignment?
We should do what Safari does.

Powered by Google App Engine
This is Rietveld 408576698