Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 657923002: Make GrFragmentProcessor auto-compare coord xforms. (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@key
Visibility:
Public.

Description

Make GrFragmentProcessor auto-compare coord xforms. Committed: https://skia.googlesource.com/skia/+/de258cd6b402c4da78b66e88191ad02162d87916

Patch Set 1 #

Patch Set 2 : comment cleanup #

Patch Set 3 : Add \! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -20 lines) Patch
M include/gpu/GrCoordTransform.h View 1 chunk +6 lines, -4 lines 0 comments Download
M include/gpu/GrFragmentProcessor.h View 1 2 3 chunks +24 lines, -10 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bsalomon
saving the auto-texture comparison for a separate cl.
6 years, 2 months ago (2014-10-15 19:11:13 UTC) #2
joshualitt
On 2014/10/15 19:11:13, bsalomon wrote: > saving the auto-texture comparison for a separate cl. lgtm
6 years, 2 months ago (2014-10-15 20:57:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657923002/40001
6 years, 2 months ago (2014-10-16 01:58:22 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 02:06:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as de258cd6b402c4da78b66e88191ad02162d87916

Powered by Google App Engine
This is Rietveld 408576698