Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 657703002: Revert of [GCM] Start GCMChannelStatusSyncer when GCM is disabled (Closed)

Created:
6 years, 2 months ago by jianli
Modified:
6 years, 2 months ago
Reviewers:
fgorski
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [GCM] Start GCMChannelStatusSyncer when GCM is disabled (patchset #2 id:20001 of https://codereview.chromium.org/653843003/) Reason for revert: Reverted due to that the fix is not complete. Will fix one more issue we find and reland the patch. Original issue's description: > [GCM] Start GCMChannelStatusSyncer when GCM is disabled > > We need to start GCMChannelStatusSyncer when GCM is disabled in order > to poll the server to find out when it is reenabled. > > Also if server returns empty response, we should not treat it as error > and trigger the backoff logic. > > BUG=423415 > TEST=new tests added > > Committed: https://crrev.com/9e9dd3b7798b3500d70941af04b1325ef9a0b544 > Cr-Commit-Position: refs/heads/master@{#299518} TBR=fgorski@chromium.org NOTREECHECKS=true NOTRY=true BUG=423415 Committed: https://crrev.com/cd886410d9df48ab930f5bfdfdf761b2ecf4ba76 Cr-Commit-Position: refs/heads/master@{#299579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -80 lines) Patch
M chrome/browser/services/gcm/gcm_desktop_utils.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_request.h View 1 chunk +1 line, -8 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_request.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_request_unittest.cc View 10 chunks +4 lines, -16 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_syncer.h View 1 chunk +1 line, -3 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_syncer.cc View 2 chunks +14 lines, -18 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 1 chunk +1 line, -7 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop_unittest.cc View 3 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jianli
Created Revert of [GCM] Start GCMChannelStatusSyncer when GCM is disabled
6 years, 2 months ago (2014-10-14 23:13:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657703002/1
6 years, 2 months ago (2014-10-14 23:14:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 23:16:22 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 23:17:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd886410d9df48ab930f5bfdfdf761b2ecf4ba76
Cr-Commit-Position: refs/heads/master@{#299579}

Powered by Google App Engine
This is Rietveld 408576698