Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: components/gcm_driver/gcm_driver_desktop_unittest.cc

Issue 657703002: Revert of [GCM] Start GCMChannelStatusSyncer when GCM is disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/gcm_driver/gcm_driver_desktop.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/gcm_driver/gcm_driver_desktop.h" 5 #include "components/gcm_driver/gcm_driver_desktop.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/files/scoped_temp_dir.h" 9 #include "base/files/scoped_temp_dir.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 1073 matching lines...) Expand 10 before | Expand all | Expand 10 after
1084 // Wait until next GCM channel status request gets triggered. 1084 // Wait until next GCM channel status request gets triggered.
1085 PumpUILoop(); 1085 PumpUILoop();
1086 1086
1087 // Complete the request that enables the GCM. 1087 // Complete the request that enables the GCM.
1088 CompleteGCMChannelStatusRequest(true, 0); 1088 CompleteGCMChannelStatusRequest(true, 0);
1089 EXPECT_TRUE(driver()->gcm_enabled()); 1089 EXPECT_TRUE(driver()->gcm_enabled());
1090 EXPECT_TRUE(syncer()->gcm_enabled()); 1090 EXPECT_TRUE(syncer()->gcm_enabled());
1091 EXPECT_TRUE(driver()->IsStarted()); 1091 EXPECT_TRUE(driver()->IsStarted());
1092 } 1092 }
1093 1093
1094 TEST_F(GCMChannelStatusSyncerTest, DisableRestartAndEnable) { 1094 TEST_F(GCMChannelStatusSyncerTest, DisableAndRestart) {
1095 // Create GCMDriver first. GCM is not started. 1095 // Create GCMDriver first. GCM is not started.
1096 CreateDriver(FakeGCMClient::NO_DELAY_START); 1096 CreateDriver(FakeGCMClient::NO_DELAY_START);
1097 EXPECT_FALSE(driver()->IsStarted()); 1097 EXPECT_FALSE(driver()->IsStarted());
1098 1098
1099 // By default, GCM is enabled. 1099 // By default, GCM is enabled.
1100 EXPECT_TRUE(driver()->gcm_enabled()); 1100 EXPECT_TRUE(driver()->gcm_enabled());
1101 EXPECT_TRUE(syncer()->gcm_enabled()); 1101 EXPECT_TRUE(syncer()->gcm_enabled());
1102 1102
1103 // Remove delay such that the request could be executed immediately. 1103 // Remove delay such that the request could be executed immediately.
1104 syncer()->set_delay_removed_for_testing(true); 1104 syncer()->set_delay_removed_for_testing(true);
(...skipping 12 matching lines...) Expand all
1117 // Complete the request that disables the GCM. 1117 // Complete the request that disables the GCM.
1118 CompleteGCMChannelStatusRequest(false, 0); 1118 CompleteGCMChannelStatusRequest(false, 0);
1119 EXPECT_FALSE(driver()->gcm_enabled()); 1119 EXPECT_FALSE(driver()->gcm_enabled());
1120 EXPECT_FALSE(syncer()->gcm_enabled()); 1120 EXPECT_FALSE(syncer()->gcm_enabled());
1121 EXPECT_FALSE(driver()->IsStarted()); 1121 EXPECT_FALSE(driver()->IsStarted());
1122 1122
1123 // Simulate browser start by recreating GCMDriver. 1123 // Simulate browser start by recreating GCMDriver.
1124 ShutdownDriver(); 1124 ShutdownDriver();
1125 CreateDriver(FakeGCMClient::NO_DELAY_START); 1125 CreateDriver(FakeGCMClient::NO_DELAY_START);
1126 1126
1127 // Remove delay such that the request could be executed immediately.
1128 syncer()->set_delay_removed_for_testing(true);
1129
1130 // GCM is still disabled. 1127 // GCM is still disabled.
1131 EXPECT_FALSE(driver()->gcm_enabled()); 1128 EXPECT_FALSE(driver()->gcm_enabled());
1132 EXPECT_FALSE(syncer()->gcm_enabled()); 1129 EXPECT_FALSE(syncer()->gcm_enabled());
1133 EXPECT_FALSE(driver()->IsStarted()); 1130 EXPECT_FALSE(driver()->IsStarted());
1134 1131
1135 AddAppHandlers(); 1132 AddAppHandlers();
1136 EXPECT_FALSE(driver()->gcm_enabled()); 1133 EXPECT_FALSE(driver()->gcm_enabled());
1137 EXPECT_FALSE(syncer()->gcm_enabled()); 1134 EXPECT_FALSE(syncer()->gcm_enabled());
1138 EXPECT_FALSE(driver()->IsStarted()); 1135 EXPECT_FALSE(driver()->IsStarted());
1139
1140 // Wait until the GCM channel status request gets triggered.
1141 PumpUILoop();
1142
1143 // Complete the request that re-enables the GCM.
1144 CompleteGCMChannelStatusRequest(true, 0);
1145 EXPECT_TRUE(driver()->gcm_enabled());
1146 EXPECT_TRUE(syncer()->gcm_enabled());
1147 EXPECT_TRUE(driver()->IsStarted());
1148 } 1136 }
1149 1137
1150 TEST_F(GCMChannelStatusSyncerTest, FirstTimePolling) { 1138 TEST_F(GCMChannelStatusSyncerTest, FirstTimePolling) {
1151 // Start GCM. 1139 // Start GCM.
1152 CreateDriver(FakeGCMClient::NO_DELAY_START); 1140 CreateDriver(FakeGCMClient::NO_DELAY_START);
1153 AddAppHandlers(); 1141 AddAppHandlers();
1154 1142
1155 // The 1st request should be triggered shortly without jittering. 1143 // The 1st request should be triggered shortly without jittering.
1156 EXPECT_EQ(GCMChannelStatusSyncer::first_time_delay_seconds(), 1144 EXPECT_EQ(GCMChannelStatusSyncer::first_time_delay_seconds(),
1157 syncer()->current_request_delay_interval().InSeconds()); 1145 syncer()->current_request_delay_interval().InSeconds());
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
1236 // After start-up, the request should still be scheduled at the expected 1224 // After start-up, the request should still be scheduled at the expected
1237 // updated interval. 1225 // updated interval.
1238 actual_delay_seconds = 1226 actual_delay_seconds =
1239 syncer()->current_request_delay_interval().InSeconds(); 1227 syncer()->current_request_delay_interval().InSeconds();
1240 EXPECT_TRUE(CompareDelaySeconds(expected_delay_seconds, actual_delay_seconds)) 1228 EXPECT_TRUE(CompareDelaySeconds(expected_delay_seconds, actual_delay_seconds))
1241 << "expected delay: " << expected_delay_seconds 1229 << "expected delay: " << expected_delay_seconds
1242 << " actual delay: " << actual_delay_seconds; 1230 << " actual delay: " << actual_delay_seconds;
1243 } 1231 }
1244 1232
1245 } // namespace gcm 1233 } // namespace gcm
OLDNEW
« no previous file with comments | « components/gcm_driver/gcm_driver_desktop.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698