Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 657513002: HTML Meter tag should have MSAA+IA2 as ROLE_SYSTEM_PROGRESSBAR. (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

HTML Meter tag should have MSAA+IA2 as ROLE_SYSTEM_PROGRESSBAR. According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html meter tag should have MSAA+IA2 Role as ROLE_SYSTEM_PROGRESSBAR. And for mac, the AX Mappings should be copy of ARIA role progressbar. This CL depends on https://codereview.chromium.org/652663003/ This CL also takes care of small fixes related with details tag and div tag. BUG=421376 Committed: https://crrev.com/e85a773cf9ea6d1ea8aac225a1c265ec58e8ef74 Cr-Commit-Position: refs/heads/master@{#299944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/common/extensions/api/automation.idl View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/meter-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/meter-expected-win.txt View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
shreeramk
Please review. Thanks :)
6 years, 2 months ago (2014-10-16 08:46:11 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-16 17:06:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657513002/1
6 years, 2 months ago (2014-10-16 17:08:18 UTC) #6
not at google - send to devlin
lgtm
6 years, 2 months ago (2014-10-16 17:09:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 18:49:42 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 18:50:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e85a773cf9ea6d1ea8aac225a1c265ec58e8ef74
Cr-Commit-Position: refs/heads/master@{#299944}

Powered by Google App Engine
This is Rietveld 408576698