content/browser/accessibility/browser_accessibility_win.cc - Issue 657513002: HTML Meter tag should have MSAA+IA2 as ROLE_SYSTEM_PROGRESSBAR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 657513002: HTML Meter tag should have MSAA+IA2 as ROLE_SYSTEM_PROGRESSBAR. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_android.cc ('k') | content/renderer/accessibility/blink_ax_enum_conversion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index e7b206c4fe6429a8fd91b05f7a09f20db461eaf0..51c0dc6560b3e9aeff52d5299591821c41c9c389 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -3452,6 +3452,7 @@ void BrowserAccessibilityWin::InitRoleAndState() {

break;

case ui::AX_ROLE_DIV:

role_name_ = L"div";

+ ia_role_ = ROLE_SYSTEM_GROUPING;

ia2_role_ = IA2_ROLE_SECTION;

break;

case ui::AX_ROLE_DEFINITION:

@@ -3474,6 +3475,7 @@ void BrowserAccessibilityWin::InitRoleAndState() {

ia_state_ |= STATE_SYSTEM_READONLY;

break;

case ui::AX_ROLE_DETAILS:

+ role_name_ = html_tag;

ia_role_ = ROLE_SYSTEM_GROUPING;

break;

case ui::AX_ROLE_DIALOG:

@@ -3636,6 +3638,10 @@ void BrowserAccessibilityWin::InitRoleAndState() {

ia_state_ |= STATE_SYSTEM_FOCUSED;

}

break;

+ case ui::AX_ROLE_METER:

+ role_name_ = html_tag;

+ ia_role_ = ROLE_SYSTEM_PROGRESSBAR;

+ break;

case ui::AX_ROLE_NAVIGATION:

ia_role_ = ROLE_SYSTEM_GROUPING;

ia2_role_ = IA2_ROLE_SECTION;