Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
index 66568375c8b4f636a51986646dc3056c090b2cac..700183d517746f9467f2d6fcb9dfa484276bc22f 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
@@ -51,8 +51,7 @@ class TestSafeBrowsingUIManager: public SafeBrowsingUIManager {
: SafeBrowsingUIManager(service) {
}
- virtual void SendSerializedMalwareDetails(
- const std::string& serialized) override {
+ void SendSerializedMalwareDetails(const std::string& serialized) override {
details_.push_back(serialized);
}
@@ -61,7 +60,7 @@ class TestSafeBrowsingUIManager: public SafeBrowsingUIManager {
}
private:
- virtual ~TestSafeBrowsingUIManager() {}
+ ~TestSafeBrowsingUIManager() override {}
std::list<std::string> details_;
};
@@ -70,9 +69,9 @@ class TestSafeBrowsingBlockingPageFactory
: public SafeBrowsingBlockingPageFactory {
public:
TestSafeBrowsingBlockingPageFactory() { }
- virtual ~TestSafeBrowsingBlockingPageFactory() { }
+ ~TestSafeBrowsingBlockingPageFactory() override {}
- virtual SafeBrowsingBlockingPage* CreateSafeBrowsingPage(
+ SafeBrowsingBlockingPage* CreateSafeBrowsingPage(
SafeBrowsingUIManager* manager,
WebContents* web_contents,
const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources)

Powered by Google App Engine
This is Rietveld 408576698