Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <list> 5 #include <list>
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/safe_browsing/malware_details.h" 10 #include "chrome/browser/safe_browsing/malware_details.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 DontCreateViewForTesting(); 44 DontCreateViewForTesting();
45 } 45 }
46 }; 46 };
47 47
48 class TestSafeBrowsingUIManager: public SafeBrowsingUIManager { 48 class TestSafeBrowsingUIManager: public SafeBrowsingUIManager {
49 public: 49 public:
50 explicit TestSafeBrowsingUIManager(SafeBrowsingService* service) 50 explicit TestSafeBrowsingUIManager(SafeBrowsingService* service)
51 : SafeBrowsingUIManager(service) { 51 : SafeBrowsingUIManager(service) {
52 } 52 }
53 53
54 virtual void SendSerializedMalwareDetails( 54 void SendSerializedMalwareDetails(const std::string& serialized) override {
55 const std::string& serialized) override {
56 details_.push_back(serialized); 55 details_.push_back(serialized);
57 } 56 }
58 57
59 std::list<std::string>* GetDetails() { 58 std::list<std::string>* GetDetails() {
60 return &details_; 59 return &details_;
61 } 60 }
62 61
63 private: 62 private:
64 virtual ~TestSafeBrowsingUIManager() {} 63 ~TestSafeBrowsingUIManager() override {}
65 64
66 std::list<std::string> details_; 65 std::list<std::string> details_;
67 }; 66 };
68 67
69 class TestSafeBrowsingBlockingPageFactory 68 class TestSafeBrowsingBlockingPageFactory
70 : public SafeBrowsingBlockingPageFactory { 69 : public SafeBrowsingBlockingPageFactory {
71 public: 70 public:
72 TestSafeBrowsingBlockingPageFactory() { } 71 TestSafeBrowsingBlockingPageFactory() { }
73 virtual ~TestSafeBrowsingBlockingPageFactory() { } 72 ~TestSafeBrowsingBlockingPageFactory() override {}
74 73
75 virtual SafeBrowsingBlockingPage* CreateSafeBrowsingPage( 74 SafeBrowsingBlockingPage* CreateSafeBrowsingPage(
76 SafeBrowsingUIManager* manager, 75 SafeBrowsingUIManager* manager,
77 WebContents* web_contents, 76 WebContents* web_contents,
78 const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources) 77 const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources)
79 override { 78 override {
80 return new TestSafeBrowsingBlockingPage(manager, web_contents, 79 return new TestSafeBrowsingBlockingPage(manager, web_contents,
81 unsafe_resources); 80 unsafe_resources);
82 } 81 }
83 }; 82 };
84 83
85 } // namespace 84 } // namespace
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
657 656
658 EXPECT_TRUE(profile->GetPrefs()->GetBoolean( 657 EXPECT_TRUE(profile->GetPrefs()->GetBoolean(
659 prefs::kSafeBrowsingExtendedReportingEnabled)); 658 prefs::kSafeBrowsingExtendedReportingEnabled));
660 659
661 // Simulate the user uncheck the report agreement checkbox. 660 // Simulate the user uncheck the report agreement checkbox.
662 sb_interstitial->SetReportingPreference(false); 661 sb_interstitial->SetReportingPreference(false);
663 662
664 EXPECT_FALSE(profile->GetPrefs()->GetBoolean( 663 EXPECT_FALSE(profile->GetPrefs()->GetBoolean(
665 prefs::kSafeBrowsingExtendedReportingEnabled)); 664 prefs::kSafeBrowsingExtendedReportingEnabled));
666 } 665 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698