Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 657293007: For certain record_wpr unittests, use --browser flag. (Closed)

Created:
6 years, 2 months ago by ariblue
Modified:
6 years, 2 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

For certain record_wpr unittests, use --browser flag. Some of the record_wpr unittests are causing issues. By passing in the --browser flag with the existing browser_type for these tests, we should be able to avoid this flakiness (caused by waiting for another browser to finish launching). BUG=424439 Committed: https://crrev.com/fd0beb29644013f310edda3efaf162c43c9cee59 Cr-Commit-Position: refs/heads/master@{#300045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ariblue
6 years, 2 months ago (2014-10-17 01:36:06 UTC) #2
tonyg
This makes sense, but can't you define issues a little better in the CL description? ...
6 years, 2 months ago (2014-10-17 01:38:16 UTC) #3
tonyg
On 2014/10/17 01:38:16, tonyg wrote: > This makes sense, but can't you define issues a ...
6 years, 2 months ago (2014-10-17 01:38:46 UTC) #4
ariblue
On 2014/10/17 01:38:46, tonyg wrote: > On 2014/10/17 01:38:16, tonyg wrote: > > This makes ...
6 years, 2 months ago (2014-10-17 01:58:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657293007/1
6 years, 2 months ago (2014-10-17 02:02:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 02:28:58 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 02:29:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd0beb29644013f310edda3efaf162c43c9cee59
Cr-Commit-Position: refs/heads/master@{#300045}

Powered by Google App Engine
This is Rietveld 408576698