tools/telemetry/telemetry/page/record_wpr_unittest.py - Issue 657293007: For certain record_wpr unittests, use --browser flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/record_wpr_unittest.py

Issue 657293007: For certain record_wpr unittests, use --browser flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/record_wpr_unittest.py

diff --git a/tools/telemetry/telemetry/page/record_wpr_unittest.py b/tools/telemetry/telemetry/page/record_wpr_unittest.py

index 75e79b2adaa6ccf4d086cf9511ea6a41e9293bb6..13709627714a71d6ed8121ba858f42f6ecaa4e2f 100644

--- a/tools/telemetry/telemetry/page/record_wpr_unittest.py

+++ b/tools/telemetry/telemetry/page/record_wpr_unittest.py

@@ -145,7 +145,7 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):

@decorators.Disabled('chromeos') # crbug.com/404868.

def testWprRecorderWithPageSet(self):

- flags = []

+ flags = ['--browser', self._browser.browser_type]

mock_page_set = MockPageSet(url=self._url)

wpr_recorder = record_wpr.WprRecorder(self._test_data_dir,

mock_page_set, flags)

@@ -154,7 +154,8 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):

self.assertEqual(set(mock_page_set.pages), results.pages_that_succeeded)

def testWprRecorderWithBenchmark(self):

- flags = ['--mock-benchmark-url', self._url]

+ flags = ['--mock-benchmark-url', self._url,

+ '--browser', self._browser.browser_type]

mock_benchmark = MockBenchmark()

wpr_recorder = record_wpr.WprRecorder(self._test_data_dir, mock_benchmark,

flags)

« no previous file with comments | « no previous file | no next file » | no next file with comments »