Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 657293004: Remove unused GC::writePixels() wrapper. (Closed)

Created:
6 years, 2 months ago by f(malita)
Modified:
6 years, 2 months ago
CC:
blink-reviews, krit, Rik, jbroman, mkwst+moarreviews_chromium.org, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove unused GC::writePixels() wrapper. (only used in unit tests) R=schenney@chromium.org,senorblanco@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183846

Patch Set 1 #

Total comments: 2

Patch Set 2 : unit test helper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M Source/platform/graphics/GraphicsContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/platform/graphics/GraphicsContextTest.cpp View 1 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
f(malita)
Daily GC scrub.
6 years, 2 months ago (2014-10-16 21:46:25 UTC) #1
Stephen White
LGTM, nit at your discretion https://codereview.chromium.org/657293004/diff/1/Source/platform/graphics/GraphicsContextTest.cpp File Source/platform/graphics/GraphicsContextTest.cpp (right): https://codereview.chromium.org/657293004/diff/1/Source/platform/graphics/GraphicsContextTest.cpp#newcode789 Source/platform/graphics/GraphicsContextTest.cpp:789: { Nit: maybe we ...
6 years, 2 months ago (2014-10-16 21:48:33 UTC) #2
f(malita)
https://codereview.chromium.org/657293004/diff/1/Source/platform/graphics/GraphicsContextTest.cpp File Source/platform/graphics/GraphicsContextTest.cpp (right): https://codereview.chromium.org/657293004/diff/1/Source/platform/graphics/GraphicsContextTest.cpp#newcode789 Source/platform/graphics/GraphicsContextTest.cpp:789: { On 2014/10/16 21:48:33, Stephen White wrote: > Nit: ...
6 years, 2 months ago (2014-10-16 22:02:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657293004/20001
6 years, 2 months ago (2014-10-16 23:12:54 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 00:24:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183846

Powered by Google App Engine
This is Rietveld 408576698