Remove unused GC::writePixels() wrapper.

Source/platform/graphics/GraphicsContextTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 768 matching lines @@
 
     SkBitmap alphaBitmap;
     alphaBitmap.allocN32Pixels(10, 10);
     for (int y = 0; y < alphaBitmap.height(); ++y)
         for (int x = 0; x < alphaBitmap.width(); ++x)
             *alphaBitmap.getAddr32(x, y) = 0x00000000;
 
     SkPaint paint;
     paint.setXfermodeMode(SkXfermode::kSrc_Mode);
 
-    context.writePixels(opaqueBitmap, 50, 50);
+    {

[Stephen White, 2014/10/16 21:48:33]

Nit: maybe we should make writePixels a helper function in this file, to save
writing the same stanza 5 times below?

[f(malita), 2014/10/16 22:02:19]

Thanks, done.

+        SkAutoLockPixels locker(opaqueBitmap);
+        context.writePixels(opaqueBitmap.info(), opaqueBitmap.getPixels(), opaqueBitmap.rowBytes(),
+            50, 50);
+    }
     EXPECT_EQ_RECT(IntRect(50, 50, 10, 10), context.opaqueRegion().asRect());
     EXPECT_PIXELS_MATCH(bitmap, context.opaqueRegion().asRect());
 
     context.fillRect(FloatRect(10, 10, 90, 90), opaque, CompositeSourceOver);
     EXPECT_EQ_RECT(IntRect(10, 10, 90, 90), context.opaqueRegion().asRect());
     EXPECT_PIXELS_MATCH(bitmap, context.opaqueRegion().asRect());
 
-    context.writePixels(alphaBitmap, 10, 0);
+    {
+        SkAutoLockPixels locker(alphaBitmap);
+        context.writePixels(alphaBitmap.info(), alphaBitmap.getPixels(), alphaBitmap.rowBytes(),
+            10, 0);
+    }
     EXPECT_EQ_RECT(IntRect(10, 10, 90, 90), context.opaqueRegion().asRect());
     EXPECT_PIXELS_MATCH(bitmap, context.opaqueRegion().asRect());
 
-    context.writePixels(alphaBitmap, 10, 1);
+    {
+        SkAutoLockPixels locker(alphaBitmap);
+        context.writePixels(alphaBitmap.info(), alphaBitmap.getPixels(), alphaBitmap.rowBytes(),
+            10, 1);
+    }
     EXPECT_EQ_RECT(IntRect(10, 11, 90, 89), context.opaqueRegion().asRect());
     EXPECT_PIXELS_MATCH(bitmap, context.opaqueRegion().asRect());
 
-    context.writePixels(alphaBitmap, 0, 10);
+    {
+        SkAutoLockPixels locker(alphaBitmap);
+        context.writePixels(alphaBitmap.info(), alphaBitmap.getPixels(), alphaBitmap.rowBytes(),
+            0, 10);
+    }
     EXPECT_EQ_RECT(IntRect(10, 11, 90, 89), context.opaqueRegion().asRect());
     EXPECT_PIXELS_MATCH(bitmap, context.opaqueRegion().asRect());
 
-    context.writePixels(alphaBitmap, 1, 10);
+    {
+        SkAutoLockPixels locker(alphaBitmap);
+        context.writePixels(alphaBitmap.info(), alphaBitmap.getPixels(), alphaBitmap.rowBytes(),
+            1, 10);
+    }
     EXPECT_EQ_RECT(IntRect(11, 11, 89, 89), context.opaqueRegion().asRect());
     EXPECT_PIXELS_MATCH(bitmap, context.opaqueRegion().asRect());
 }
 
 TEST(GraphicsContextTest, trackOpaqueDrawBitmapTest)
 {
     SkBitmap bitmap;
     bitmap.allocN32Pixels(200, 200);
     bitmap.eraseColor(0);
     SkCanvas canvas(bitmap);
@@ skipping 388 matching lines @@
     // endRecording finally makes the picture accessible
     RefPtr<DisplayList> dl = context.endRecording();
     SkPicture* pic = dl->picture();
     EXPECT_TRUE(pic);
     EXPECT_EQ(1, pic->getRefCnt());
 
     context.endRecording();
 }
 
 } // namespace