Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 657143002: Set an href for the extension options pages link to get the correct mouse over (Closed)

Created:
6 years, 2 months ago by not at google - send to devlin
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set an href for the extension options pages link to get the correct mouse over behaviour. BUG=409319 R=mek@chromium.org Committed: https://crrev.com/55721c1fd3bb640d29491407572c7dbb56975ca5 Cr-Commit-Position: refs/heads/master@{#299749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/resources/extensions/extension_list.js View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
not at google - send to devlin
6 years, 2 months ago (2014-10-15 17:58:03 UTC) #1
Marijn Kruisselbrink
lgtm
6 years, 2 months ago (2014-10-15 17:59:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657143002/1
6 years, 2 months ago (2014-10-15 18:06:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 20:08:25 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 20:09:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55721c1fd3bb640d29491407572c7dbb56975ca5
Cr-Commit-Position: refs/heads/master@{#299749}

Powered by Google App Engine
This is Rietveld 408576698