Chromium Code Reviews

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 657143002: Set an href for the extension options pages link to get the correct mouse over (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
6 6
7 #include "apps/app_load_service.h" 7 #include "apps/app_load_service.h"
8 #include "apps/saved_files_service.h" 8 #include "apps/saved_files_service.h"
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/base64.h" 10 #include "base/base64.h"
(...skipping 269 matching lines...)
280 extension_data->SetBoolean("allowFileAccess", 280 extension_data->SetBoolean("allowFileAccess",
281 util::AllowFileAccess(extension->id(), extension_service_->profile())); 281 util::AllowFileAccess(extension->id(), extension_service_->profile()));
282 extension_data->SetBoolean("allow_reload", 282 extension_data->SetBoolean("allow_reload",
283 Manifest::IsUnpackedLocation(extension->location())); 283 Manifest::IsUnpackedLocation(extension->location()));
284 extension_data->SetBoolean("is_hosted_app", extension->is_hosted_app()); 284 extension_data->SetBoolean("is_hosted_app", extension->is_hosted_app());
285 extension_data->SetBoolean("is_platform_app", extension->is_platform_app()); 285 extension_data->SetBoolean("is_platform_app", extension->is_platform_app());
286 extension_data->SetBoolean("homepageProvided", 286 extension_data->SetBoolean("homepageProvided",
287 ManifestURL::SpecifiedHomepageURL(extension)); 287 ManifestURL::SpecifiedHomepageURL(extension));
288 extension_data->SetBoolean("optionsOpenInTab", 288 extension_data->SetBoolean("optionsOpenInTab",
289 OptionsPageInfo::ShouldOpenInTab(extension)); 289 OptionsPageInfo::ShouldOpenInTab(extension));
290 extension_data->SetString("optionsPageHref",
291 OptionsPageInfo::GetOptionsPage(extension).spec());
290 292
291 // Add dependent extensions. 293 // Add dependent extensions.
292 base::ListValue* dependents_list = new base::ListValue; 294 base::ListValue* dependents_list = new base::ListValue;
293 if (extension->is_shared_module()) { 295 if (extension->is_shared_module()) {
294 scoped_ptr<ExtensionSet> dependent_extensions = 296 scoped_ptr<ExtensionSet> dependent_extensions =
295 extension_service_->shared_module_service()->GetDependentExtensions( 297 extension_service_->shared_module_service()->GetDependentExtensions(
296 extension); 298 extension);
297 for (ExtensionSet::const_iterator i = dependent_extensions->begin(); 299 for (ExtensionSet::const_iterator i = dependent_extensions->begin();
298 i != dependent_extensions->end(); 300 i != dependent_extensions->end();
299 i++) { 301 i++) {
(...skipping 1197 matching lines...)
1497 extension_service_->EnableExtension(extension_id); 1499 extension_service_->EnableExtension(extension_id);
1498 } else { 1500 } else {
1499 ExtensionErrorReporter::GetInstance()->ReportError( 1501 ExtensionErrorReporter::GetInstance()->ReportError(
1500 base::UTF8ToUTF16(JoinString(requirement_errors, ' ')), 1502 base::UTF8ToUTF16(JoinString(requirement_errors, ' ')),
1501 true); // Be noisy. 1503 true); // Be noisy.
1502 } 1504 }
1503 requirements_checker_.reset(); 1505 requirements_checker_.reset();
1504 } 1506 }
1505 1507
1506 } // namespace extensions 1508 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine