Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: mojo/services/public/interfaces/network/network_service.mojom

Issue 657113002: Add basic TCP socket mojo implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/interfaces/network/network_service.mojom
diff --git a/mojo/services/public/interfaces/network/network_service.mojom b/mojo/services/public/interfaces/network/network_service.mojom
index 74f931214ae8fd4f92ae19858b10c99224e34dc4..e039780289e18442f50a16e9df89c9e9c03b2be0 100644
--- a/mojo/services/public/interfaces/network/network_service.mojom
+++ b/mojo/services/public/interfaces/network/network_service.mojom
@@ -45,6 +45,11 @@ interface NetworkService {
//
// If you want control over the local address and port, instead use
// CreateTCPBoundSocket.
+ //
+ // IMPORTANT: This does not work yet! We need to add a new parameter to
+ // indicate the protocol type (IPv4 or IPv6) actually be able to create the
+ // right type of socket. We also need to figure out how the client is supposed
+ // to decide between IPv4 and IPv6 on a given system.
CreateTCPConnectedSocket(NetAddress remote_address,
handle<data_pipe_consumer> send_stream,
handle<data_pipe_producer> receive_stream,

Powered by Google App Engine
This is Rietveld 408576698