chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc - Issue 657023008: Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

Issue 657023008: Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc ('K') | « chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | chrome/browser/ui/extensions/application_launch.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

index 34a8f6aa91c9ac293cdb485e08d9d6235ad3076b..3197ea073a5b9dcac243ddccc35631b1e5888088 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

@@ -739,6 +739,10 @@ void ChromeLauncherController::LaunchApp(const std::string& app_id,

extension_url, extension_urls::kWebstoreSourceField, source_value);

}

+ params.source = (source == ash::LAUNCH_FROM_UNKNOWN)

+ ? extensions::SOURCE_UNKNOWN

+ : extensions::SOURCE_APP_LAUNCHER;

OpenApplication(params);

}

@@ -1756,7 +1760,7 @@ void ChromeLauncherController::SetVirtualKeyboardBehaviorFromPrefs() {

else if (is_enabled && !was_enabled)

ash::Shell::GetInstance()->CreateKeyboard();

}

-#endif // defined(OS_CHROMEOS)

+#endif // defined(OS_CHROMEOS)

ash::ShelfItemStatus ChromeLauncherController::GetAppState(

const std::string& app_id) {