chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc - Issue 657023008: Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

Issue 657023008: Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/app_launch_for_metro_restart_win.cc ('K') | « chrome/browser/apps/app_launch_for_metro_restart_win.cc ('k') | chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc » ('j') | chrome/browser/ui/extensions/application_launch.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

diff --git a/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc b/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

index 6223af348706ee50b8723afe509731c3ebfa3ceb..f86b10a955e918a6e535cc28bc4073251db83435 100644

--- a/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

+++ b/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

@@ -28,6 +28,7 @@

#include "extensions/browser/app_window/native_app_window.h"

#include "extensions/browser/extension_host.h"

#include "extensions/browser/extension_registry.h"

+#include "extensions/common/constants.h"

#include "ui/base/cocoa/focus_window_set.h"

using extensions::AppWindow;

@@ -186,7 +187,7 @@ void ExtensionAppShimHandler::Delegate::LaunchApp(

CoreAppLauncherHandler::RecordAppLaunchType(

extension_misc::APP_LAUNCH_CMD_LINE_APP, extension->GetType());

if (files.empty()) {

- apps::LaunchPlatformApp(profile, extension);

+ apps::LaunchPlatformApp(profile, extension, extensions::SOURCE_UNKNOWN);

benwells 2014/10/28 21:22:47 This should not be unknown, it should be SOURCE_CO

cylee1 2014/10/29 16:39:59 Done.

} else {

for (std::vector<base::FilePath>::const_iterator it = files.begin();

it != files.end(); ++it) {