Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source.

apps/app_load_service.cc

Index: apps/app_load_service.cc
diff --git a/apps/app_load_service.cc b/apps/app_load_service.cc
index fe224c5e8ebf7b64a0d2a419ca001be383bc6eaf..4444f873255b8fb830607219c9896bedbe2f0ef1 100644
--- a/apps/app_load_service.cc
+++ b/apps/app_load_service.cc
@@ -99,14 +99,18 @@ void AppLoadService::Observe(int type,
 
   switch (it->second.action_type) {
     case LAUNCH:
-      LaunchPlatformApp(profile_, extension);
+      LaunchPlatformAppWithSource(
+          profile_, extension, extensions::SOURCE_RELOAD);

[benwells, 2014/10/21 03:51:57]

This is unclear. Also, the source for LAUNCH_WITH_COMMAND_LINE is wrong (it
should be something new, as this comes from the --load-and-launch command line
flag).

I think either you should keep this code basically as is but rename LAUNCH and
LAUNCH_WITH_COMMAND_LINE to make it more obvious why the sources follow, or you
should add source as a field on the PostReloadAction struct.

[cylee1, 2014/10/21 13:41:16]

To be honest I don't get the "case LAUNCH:" case
It's setup when OnExtensionUnloaded(), I don't understand when should we launch
an app when it's unloaded. Could you give me an example and maybe a suggested
name?

       break;
     case RESTART:
       RestartPlatformApp(profile_, extension);
       break;
     case LAUNCH_WITH_COMMAND_LINE:
-      LaunchPlatformAppWithCommandLine(
-          profile_, extension, it->second.command_line, it->second.current_dir);
+      LaunchPlatformAppWithCommandLine(profile_,
+                                       extension,
+                                       it->second.command_line,
+                                       it->second.current_dir,
+                                       extensions::SOURCE_RELOAD);
       break;
     default:
       NOTREACHED();