Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source.

apps/app_load_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/app_load_service.h"
 
 #include "apps/app_load_service_factory.h"
 #include "apps/app_restore_service.h"
 #include "apps/launcher.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 81 matching lines @@
   // It is possible for an extension to be unloaded before it stops loading.
   if (!extension)
     return;
   std::map<std::string, PostReloadAction>::iterator it =
       post_reload_actions_.find(extension->id());
   if (it == post_reload_actions_.end())
     return;
 
   switch (it->second.action_type) {
     case LAUNCH:
-      LaunchPlatformApp(profile_, extension);
+      LaunchPlatformAppWithSource(
+          profile_, extension, extensions::SOURCE_RELOAD);

[benwells, 2014/10/21 03:51:57]

This is unclear. Also, the source for LAUNCH_WITH_COMMAND_LINE is wrong (it
should be something new, as this comes from the --load-and-launch command line
flag).

I think either you should keep this code basically as is but rename LAUNCH and
LAUNCH_WITH_COMMAND_LINE to make it more obvious why the sources follow, or you
should add source as a field on the PostReloadAction struct.

[cylee1, 2014/10/21 13:41:16]

To be honest I don't get the "case LAUNCH:" case
It's setup when OnExtensionUnloaded(), I don't understand when should we launch
an app when it's unloaded. Could you give me an example and maybe a suggested
name?

       break;
     case RESTART:
       RestartPlatformApp(profile_, extension);
       break;
     case LAUNCH_WITH_COMMAND_LINE:
-      LaunchPlatformAppWithCommandLine(
-          profile_, extension, it->second.command_line, it->second.current_dir);
+      LaunchPlatformAppWithCommandLine(profile_,
+                                       extension,
+                                       it->second.command_line,
+                                       it->second.current_dir,
+                                       extensions::SOURCE_RELOAD);
       break;
     default:
       NOTREACHED();
   }
 
   post_reload_actions_.erase(it);
 }
 
 void AppLoadService::OnExtensionUnloaded(
     content::BrowserContext* browser_context,
@@ skipping 20 matching lines @@
             Extension::DISABLE_RELOAD) != 0;
   }
   return false;
 }
 
 bool AppLoadService::HasPostReloadAction(const std::string& extension_id) {
   return post_reload_actions_.find(extension_id) != post_reload_actions_.end();
 }
 
 }  // namespace apps