Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 657013003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, gavinp+disk_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/e3d1ddcf059c2c22577489e5235fb1cbafd29e88 Cr-Commit-Position: refs/heads/master@{#299741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -123 lines) Patch
M net/disk_cache/disk_cache_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/memory/mem_backend_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_index_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/dns/dns_session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/mapped_host_resolver_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/dns/mdns_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M net/http/http_stream_parser_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/ocsp/nss_ocsp_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/quic_end_to_end_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_base.h View 1 chunk +1 line, -4 lines 0 comments Download
M net/socket/socket_test_util.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 13 chunks +22 lines, -40 lines 0 comments Download
M net/socket/tcp_listen_socket.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/socket/transport_client_socket_pool_test_util.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/socket/unix_domain_listen_socket_posix.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_channel_test.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/websockets/websocket_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_stream_test.cc View 3 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 2 months ago (2014-10-15 17:14:15 UTC) #2
rvargas (doing something else)
lgtm
6 years, 2 months ago (2014-10-15 19:06:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657013003/1
6 years, 2 months ago (2014-10-15 19:07:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 19:31:11 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 19:31:52 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e3d1ddcf059c2c22577489e5235fb1cbafd29e88
Cr-Commit-Position: refs/heads/master@{#299741}

Powered by Google App Engine
This is Rietveld 408576698