net/http/http_stream_parser_unittest.cc - Issue 657013003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_parser_unittest.cc

Issue 657013003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_parser_unittest.cc

diff --git a/net/http/http_stream_parser_unittest.cc b/net/http/http_stream_parser_unittest.cc

index ef83638cc1dc5e7ffea24c6a9e08b0955bb74bb2..01d4e120ab1b583bae90aef127db07654e16224b 100644

--- a/net/http/http_stream_parser_unittest.cc

+++ b/net/http/http_stream_parser_unittest.cc

@@ -236,7 +236,7 @@ TEST(HttpStreamParser, AsyncChunkAndAsyncSocket) {

ASSERT_EQ(OK, rv);

scoped_ptr<ClientSocketHandle> socket_handle(new ClientSocketHandle);

- socket_handle->SetSocket(transport.PassAs<StreamSocket>());

+ socket_handle->SetSocket(transport.Pass());

HttpRequestInfo request_info;

request_info.method = "GET";

@@ -391,7 +391,7 @@ TEST(HttpStreamParser, TruncatedHeaders) {

ASSERT_EQ(OK, rv);

scoped_ptr<ClientSocketHandle> socket_handle(new ClientSocketHandle);

- socket_handle->SetSocket(transport.PassAs<StreamSocket>());

+ socket_handle->SetSocket(transport.Pass());

HttpRequestInfo request_info;

request_info.method = "GET";

@@ -460,7 +460,7 @@ TEST(HttpStreamParser, Websocket101Response) {

ASSERT_EQ(OK, rv);

scoped_ptr<ClientSocketHandle> socket_handle(new ClientSocketHandle);

- socket_handle->SetSocket(transport.PassAs<StreamSocket>());

+ socket_handle->SetSocket(transport.Pass());

HttpRequestInfo request_info;

request_info.method = "GET";

@@ -530,7 +530,7 @@ class SimpleGetRunner {

rv = callback.GetResult(rv);

ASSERT_EQ(OK, rv);

- socket_handle_->SetSocket(transport_.PassAs<StreamSocket>());

+ socket_handle_->SetSocket(transport_.Pass());

request_info_.method = "GET";

request_info_.url = GURL("http://localhost");

@@ -835,7 +835,7 @@ TEST(HttpStreamParser, ReadAfterUnownedObjectsDestroyed) {

ASSERT_EQ(OK, transport->Connect(callback.callback()));

scoped_ptr<ClientSocketHandle> socket_handle(new ClientSocketHandle);

- socket_handle->SetSocket(transport.PassAs<StreamSocket>());

+ socket_handle->SetSocket(transport.Pass());

scoped_ptr<HttpRequestInfo> request_info(new HttpRequestInfo());

request_info->method = "GET";

« no previous file with comments | « net/http/http_stream_factory_impl_unittest.cc ('k') | net/ocsp/nss_ocsp_unittest.cc » ('j') | no next file with comments »