Issue 656793005: Fix compile errors in r24826.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 656793005: Fix compile errors in r24826. (Closed)

Created:
6 years, 2 months ago by Yang

Modified:
6 years, 2 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix compile errors in r24826. TBR=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24828

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/serialize.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

Committed patchset #1 (id:1) manually as 24828 (tree was closed).

6 years, 2 months ago (2014-10-23 08:57:02 UTC) #2

Benedikt Meurer

6 years, 2 months ago (2014-10-23 08:58:08 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/656793005/diff/1/src/serialize.h
File src/serialize.h (right):

https://codereview.chromium.org/656793005/diff/1/src/serialize.h#newcode149
src/serialize.h:149: return
static_cast<uint32_t>(reinterpret_cast<intptr_t>(entry->value));
Why not just 

 return reinterpret_cast<uintptr_t>(entry->value);

instead?

Expand Messages | Collapse Messages