Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: Source/core/html/HTMLCollection.cpp

Issue 656723005: Use C++11 features in core/html (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: use nullptr Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLCollection.cpp
diff --git a/Source/core/html/HTMLCollection.cpp b/Source/core/html/HTMLCollection.cpp
index 440a0454c0429f732ae2c90dde93368464d4a45b..fa5e6021d98340bd0a344906fb5d6821ff934b49 100644
--- a/Source/core/html/HTMLCollection.cpp
+++ b/Source/core/html/HTMLCollection.cpp
@@ -301,7 +301,7 @@ static inline IsMatch<HTMLCollectionType> makeIsMatch(const HTMLCollectionType&
Element* HTMLCollection::virtualItemAfter(Element*) const
{
ASSERT_NOT_REACHED();
- return 0;
+ return nullptr;
}
static inline bool nameShouldBeVisibleInDocumentAll(const HTMLElement& element)
@@ -361,7 +361,7 @@ Element* HTMLCollection::traverseForwardToOffset(unsigned offset, Element& curre
if (++currentOffset == offset)
return next;
}
- return 0;
+ return nullptr;
}
if (shouldOnlyIncludeDirectChildren()) {
IsMatch<HTMLCollection> isMatch(*this);
@@ -369,7 +369,7 @@ Element* HTMLCollection::traverseForwardToOffset(unsigned offset, Element& curre
if (++currentOffset == offset)
return next;
}
- return 0;
+ return nullptr;
}
return traverseMatchingElementsForwardToOffset(currentElement, &rootNode(), offset, currentOffset, makeIsMatch(*this));
}
@@ -385,7 +385,7 @@ Element* HTMLCollection::traverseBackwardToOffset(unsigned offset, Element& curr
if (--currentOffset == offset)
return previous;
}
- return 0;
+ return nullptr;
}
return traverseMatchingElementsBackwardToOffset(currentElement, &rootNode(), offset, currentOffset, makeIsMatch(*this));
}
@@ -400,15 +400,15 @@ Element* HTMLCollection::namedItem(const AtomicString& name) const
updateIdNameCache();
const NamedItemCache& cache = namedItemCache();
- WillBeHeapVector<RawPtrWillBeMember<Element> >* idResults = cache.getElementsById(name);
+ WillBeHeapVector<RawPtrWillBeMember<Element>>* idResults = cache.getElementsById(name);
if (idResults && !idResults->isEmpty())
return idResults->first();
- WillBeHeapVector<RawPtrWillBeMember<Element> >* nameResults = cache.getElementsByName(name);
+ WillBeHeapVector<RawPtrWillBeMember<Element>>* nameResults = cache.getElementsByName(name);
if (nameResults && !nameResults->isEmpty())
return nameResults->first();
- return 0;
+ return nullptr;
}
bool HTMLCollection::namedPropertyQuery(const AtomicString& name, ExceptionState&)
@@ -422,7 +422,7 @@ void HTMLCollection::supportedPropertyNames(Vector<String>& names)
// The supported property names are the values from the list returned by these steps:
// 1. Let result be an empty list.
// 2. For each element represented by the collection, in tree order, run these substeps:
- // 1. If element has an ID which is neither the empty string nor is in result, append element's ID to result.
+ // 1. If element has an ID which is neither the empty string nor is in result, ap1pend element's ID to result.
Mike West 2014/11/04 15:25:52 Nit: s/ap1pend/append/
riju_ 2014/11/04 17:50:53 Done.
// 2. If element is in the HTML namespace and has a name attribute whose value is neither the empty string
// nor is in result, append element's name attribute value to result.
// 3. Return result.
@@ -474,7 +474,7 @@ void HTMLCollection::updateIdNameCache() const
setNamedItemCache(cache.release());
}
-void HTMLCollection::namedItems(const AtomicString& name, WillBeHeapVector<RefPtrWillBeMember<Element> >& result) const
+void HTMLCollection::namedItems(const AtomicString& name, WillBeHeapVector<RefPtrWillBeMember<Element>>& result) const
{
ASSERT(result.isEmpty());
if (name.isEmpty())
@@ -483,11 +483,11 @@ void HTMLCollection::namedItems(const AtomicString& name, WillBeHeapVector<RefPt
updateIdNameCache();
const NamedItemCache& cache = namedItemCache();
- if (WillBeHeapVector<RawPtrWillBeMember<Element> >* idResults = cache.getElementsById(name)) {
+ if (WillBeHeapVector<RawPtrWillBeMember<Element>>* idResults = cache.getElementsById(name)) {
for (unsigned i = 0; i < idResults->size(); ++i)
result.append(idResults->at(i));
}
- if (WillBeHeapVector<RawPtrWillBeMember<Element> >* nameResults = cache.getElementsByName(name)) {
+ if (WillBeHeapVector<RawPtrWillBeMember<Element>>* nameResults = cache.getElementsByName(name)) {
for (unsigned i = 0; i < nameResults->size(); ++i)
result.append(nameResults->at(i));
}

Powered by Google App Engine
This is Rietveld 408576698