Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: Source/core/html/HTMLDocument.cpp

Issue 656723005: Use C++11 features in core/html (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: use nullptr Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLDocument.cpp
diff --git a/Source/core/html/HTMLDocument.cpp b/Source/core/html/HTMLDocument.cpp
index 3183f5b286d5e5fcbce6e2c990e75f785055b43d..15d4bad00e837c67f8422d1f992dcda38359c415 100644
--- a/Source/core/html/HTMLDocument.cpp
+++ b/Source/core/html/HTMLDocument.cpp
@@ -275,8 +275,8 @@ void HTMLDocument::write(LocalDOMWindow* callingWindow, const Vector<String>& te
{
ASSERT(callingWindow);
StringBuilder builder;
- for (size_t i = 0; i < text.size(); ++i)
- builder.append(text[i]);
+ for (const auto& string : text)
Mike West 2014/11/04 15:25:52 No need for `auto` here. `const String&` is cleare
riju_ 2014/11/04 17:50:53 Done.
+ builder.append(string);
write(builder.toString(), callingWindow->document(), exceptionState);
}
@@ -284,8 +284,8 @@ void HTMLDocument::writeln(LocalDOMWindow* callingWindow, const Vector<String>&
{
ASSERT(callingWindow);
StringBuilder builder;
- for (size_t i = 0; i < text.size(); ++i)
- builder.append(text[i]);
+ for (const auto& string : text)
Mike West 2014/11/04 15:25:52 Same here.
riju_ 2014/11/04 17:50:53 Done.
+ builder.append(string);
writeln(builder.toString(), callingWindow->document(), exceptionState);
}

Powered by Google App Engine
This is Rietveld 408576698