|
Don't count UseCounters in private scripts
When I shipped marquee-in-JS, it increased UseCounters for Web Animation APIs because the marquee-in-JS uses the Web Animation APIs. This was an unexpected outcome because what we want to count is the number of JS APIs used by web developers, not the number of JS APIs used internally (i.e., private scripts).
Given the above, this CL adds UseCounter::countIfNotPrivateScript() and uses it in a binding layer so that we can count only the number of JS APIs used by web developers.
BUG= 341031
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183805
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+85 lines, -53 lines) |
Patch |
 |
M |
Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/bindings/core/v8/custom/V8ElementCustom.cpp
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/templates/attributes.cpp
|
View
|
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/templates/constants.cpp
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/templates/interface.cpp
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/templates/methods.cpp
|
View
|
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/core/V8TestObject.cpp
|
View
|
|
17 chunks |
+24 lines, -24 lines |
0 comments
|
Download
|
 |
M |
Source/core/frame/UseCounter.h
|
View
|
|
3 chunks |
+11 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/frame/UseCounter.cpp
|
View
|
|
2 chunks |
+21 lines, -0 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|