Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: Source/bindings/core/v8/custom/V8ElementCustom.cpp

Issue 656693002: Don't count UseCounters in private scripts (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 return; 174 return;
175 } 175 }
176 // AnimationPlayer animate(AnimationEffect effect); 176 // AnimationPlayer animate(AnimationEffect effect);
177 if (V8AnimationEffect::hasInstance(info[0], isolate)) { 177 if (V8AnimationEffect::hasInstance(info[0], isolate)) {
178 animate1Method(info); 178 animate1Method(info);
179 return; 179 return;
180 } 180 }
181 // [MeasureAs=ElementAnimateKeyframeListEffectNoTiming] 181 // [MeasureAs=ElementAnimateKeyframeListEffectNoTiming]
182 // AnimationPlayer animate(sequence<Dictionary> effect); 182 // AnimationPlayer animate(sequence<Dictionary> effect);
183 if (info[0]->IsArray()) { 183 if (info[0]->IsArray()) {
184 UseCounter::count(callingExecutionContext(isolate), UseCounter::Elem entAnimateKeyframeListEffectNoTiming); 184 UseCounter::countIfNotPrivateScript(isolate, callingExecutionContext (isolate), UseCounter::ElementAnimateKeyframeListEffectNoTiming);
185 animate2Method(info); 185 animate2Method(info);
186 return; 186 return;
187 } 187 }
188 break; 188 break;
189 case 2: 189 case 2:
190 // As above, null resolved to AnimationEffect 190 // As above, null resolved to AnimationEffect
191 // AnimationPlayer animate(AnimationEffect? effect, Dictionary timing); 191 // AnimationPlayer animate(AnimationEffect? effect, Dictionary timing);
192 if (info[0]->IsNull() && info[1]->IsObject()) { 192 if (info[0]->IsNull() && info[1]->IsObject()) {
193 animate4Method(info); 193 animate4Method(info);
194 return; 194 return;
(...skipping 10 matching lines...) Expand all
205 return; 205 return;
206 } 206 }
207 // AnimationPlayer animate(AnimationEffect effect, double timing); 207 // AnimationPlayer animate(AnimationEffect effect, double timing);
208 if (V8AnimationEffect::hasInstance(info[0], isolate)) { 208 if (V8AnimationEffect::hasInstance(info[0], isolate)) {
209 animate3Method(info); 209 animate3Method(info);
210 return; 210 return;
211 } 211 }
212 // [MeasureAs=ElementAnimateKeyframeListEffectObjectTiming] 212 // [MeasureAs=ElementAnimateKeyframeListEffectObjectTiming]
213 // AnimationPlayer animate(sequence<Dictionary> effect, Dictionary timin g); 213 // AnimationPlayer animate(sequence<Dictionary> effect, Dictionary timin g);
214 if (info[0]->IsArray() && info[1]->IsObject()) { 214 if (info[0]->IsArray() && info[1]->IsObject()) {
215 UseCounter::count(callingExecutionContext(isolate), UseCounter::Elem entAnimateKeyframeListEffectObjectTiming); 215 UseCounter::countIfNotPrivateScript(isolate, callingExecutionContext (isolate), UseCounter::ElementAnimateKeyframeListEffectObjectTiming);
216 animate6Method(info); 216 animate6Method(info);
217 return; 217 return;
218 } 218 }
219 // [MeasureAs=ElementAnimateKeyframeListEffectDoubleTiming] 219 // [MeasureAs=ElementAnimateKeyframeListEffectDoubleTiming]
220 // AnimationPlayer animate(sequence<Dictionary> effect, double timing); 220 // AnimationPlayer animate(sequence<Dictionary> effect, double timing);
221 if (info[0]->IsArray()) { 221 if (info[0]->IsArray()) {
222 UseCounter::count(callingExecutionContext(isolate), UseCounter::Elem entAnimateKeyframeListEffectDoubleTiming); 222 UseCounter::countIfNotPrivateScript(isolate, callingExecutionContext (isolate), UseCounter::ElementAnimateKeyframeListEffectDoubleTiming);
223 animate5Method(info); 223 animate5Method(info);
224 return; 224 return;
225 } 225 }
226 break; 226 break;
227 default: 227 default:
228 setArityTypeError(exceptionState, "[1]", info.Length()); 228 setArityTypeError(exceptionState, "[1]", info.Length());
229 exceptionState.throwIfNeeded(); 229 exceptionState.throwIfNeeded();
230 return; 230 return;
231 break; 231 break;
232 } 232 }
233 exceptionState.throwTypeError("No function was found that matched the signat ure provided."); 233 exceptionState.throwTypeError("No function was found that matched the signat ure provided.");
234 exceptionState.throwIfNeeded(); 234 exceptionState.throwIfNeeded();
235 } 235 }
236 236
237 } // namespace blink 237 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698