Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 656663004: [android] Show saved password settings. (Closed)

Created:
6 years, 1 month ago by please use gerrit instead
Modified:
6 years, 1 month ago
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org, Garrett Casto, aruslan
Base URL:
https://chromium.googlesource.com/chromium/src.git@tiny-no-hide
Project:
chromium
Visibility:
Public.

Description

[android] Show saved password settings. This patch enables showing the saved passwords settings page on Android by invoking this method: chrome::android::ChromiumApplication::ShowPasswordSettings() This is similar to the existing method: chrome::android::ChromiumApplication::ShowAutofillSettings() The new method is to be used in password management UI for Android. BUG=412150 Committed: https://crrev.com/fe68095a89368864cd50b34ac6d1f3d198dd443b Cr-Commit-Position: refs/heads/master@{#301296}

Patch Set 1 #

Messages

Total messages: 19 (8 generated)
please use gerrit instead
Aurimas: PTAL Patch Set 1. I've split this off from https://codereview.chromium.org/606153002/.
6 years, 1 month ago (2014-10-23 17:03:10 UTC) #2
aurimas (slooooooooow)
lgtm
6 years, 1 month ago (2014-10-24 20:27:27 UTC) #3
please use gerrit instead
Ted, OWNERS PTAL: - chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java - chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java - chrome/browser/android/chromium_application.h - chrome/browser/android/chromium_application.cc - chrome/test/android/unit_tests_apk/src/org/chromium/chrome/unit_tests_apk/ChromeNativeTestApplication.java
6 years, 1 month ago (2014-10-24 20:42:09 UTC) #6
please use gerrit instead
Mike, OWNERS PTAL chrome/browser/ui/passwords/manage_passwords_ui_controller.cc.
6 years, 1 month ago (2014-10-24 20:43:12 UTC) #9
please use gerrit instead
Evan, OWNERS PTAL chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc.
6 years, 1 month ago (2014-10-24 20:43:55 UTC) #12
Evan Stade
lgtm
6 years, 1 month ago (2014-10-24 20:47:42 UTC) #13
Ted C
lgtm
6 years, 1 month ago (2014-10-24 20:53:11 UTC) #14
Mike West
lgtm
6 years, 1 month ago (2014-10-25 06:00:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656663004/1
6 years, 1 month ago (2014-10-25 21:56:56 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-25 22:48:35 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-10-25 22:49:18 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe68095a89368864cd50b34ac6d1f3d198dd443b
Cr-Commit-Position: refs/heads/master@{#301296}

Powered by Google App Engine
This is Rietveld 408576698