Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 656663004: [android] Show saved password settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tiny-no-hide
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index ffa8ffad86f52e0fbb02af45a8bc9baefb900048..039f58996025381f419552f17a426c65385bc35b 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -19,6 +19,10 @@
#include "components/password_manager/core/browser/password_store.h"
#include "content/public/browser/notification_service.h"
+#if defined(OS_ANDROID)
+#include "chrome/browser/android/chromium_application.h"
+#endif
+
using autofill::PasswordFormMap;
using password_manager::PasswordFormManager;
@@ -158,9 +162,9 @@ void ManagePasswordsUIController::OnLoginsChanged(
void ManagePasswordsUIController::
NavigateToPasswordManagerSettingsPage() {
-// TODO(mkwst): chrome_pages.h is compiled out of Android. Need to figure out
-// how this navigation should work there.
-#if !defined(OS_ANDROID)
+#if defined(OS_ANDROID)
+ chrome::android::ChromiumApplication::ShowPasswordSettings();
+#else
chrome::ShowSettingsSubPage(
chrome::FindBrowserWithWebContents(web_contents()),
chrome::kPasswordManagerSubPage);

Powered by Google App Engine
This is Rietveld 408576698