Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 656503003: Move SkImage::encode to SkImageEncoder (Closed)

Created:
6 years, 2 months ago by Kimmo Kinnunen
Modified:
4 years, 7 months ago
Reviewers:
scroggo, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Move SkImage::encode to SkImageEncoder Rename SkImage::encode to SkImageEncoder::Encode. This is part of separating the image decoding and encoding code from core to images "sublibrary" of Skia. This in turn works towards being able to compile Skia library without any image encoder or decoder code, but still use the encoding and decoding with the standalone apps, such as dm. BUG=skia:2992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -18 lines) Patch
M bench/nanobench.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImage.h View 5 chunks +7 lines, -11 lines 0 comments Download
M include/core/SkImageEncoder.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M src/images/SkImageDecoder_ktx.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/images/SkImageEncoder.cpp View 3 chunks +12 lines, -0 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/KtxTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/skhello.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M tools/skpdiff/SkDiffContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Kimmo Kinnunen
6 years, 2 months ago (2014-10-20 12:44:52 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698