Docserver: Attach intro metadata to the template itself, not to an object which

Docserver: Attach intro metadata to the template itself, not to an object which
contains the template.

BUG=320339
R=yoz@chromium.org, mkearney@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235762

[not at google - send to devlin, 2013-11-16 21:54:40]

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
File chrome/common/extensions/docs/server2/intro_data_source.py (right):

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/intro_data_source.py:119: 'toc':
intro_parser.toc,
I needed to lose the extension/app differentiation here. It shouldn't matter
unless the title or TOC of a file is affected by the presence of {{is_apps}}...
and if it did matter, the comment I left on lines 100-104 is very relevant.

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
File chrome/common/extensions/docs/server2/render_servlet.py (right):

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/render_servlet.py:51: if
IsPreviewServer():
helpful for debugging.

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
File chrome/common/extensions/docs/templates/private/standard_apps_article.html
(right):

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
chrome/common/extensions/docs/templates/private/standard_apps_article.html:16:
{{+article platform:strings.app is_apps:true/}}
Changes like these are why I needed to pull the "title" and "toc" properties
onto the template itself.

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
File chrome/common/extensions/docs/templates/public/apps/api_index.html (right):

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
chrome/common/extensions/docs/templates/public/apps/api_index.html:5:
dev_apis:api_list.apps.chrome.dev) /}}
cool eh? this is what the handlebar.py roll added.

[Yoyo Zhou, 2013-11-17 22:12:46]

LGTM

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
File chrome/common/extensions/docs/server2/template_renderer.py (right):

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/template_renderer.py:21: include the
DataSources with the given names when rendering the template.
nit: document warn

[not at google - send to devlin, 2013-11-18 18:05:36]

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
File chrome/common/extensions/docs/server2/template_renderer.py (right):

https://codereview.chromium.org/65643009/diff/20001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/template_renderer.py:21: include the
DataSources with the given names when rendering the template.
On 2013/11/17 22:12:47, Yoyo Zhou wrote:
> nit: document warn

Done.

[not at google - send to devlin, 2013-11-18 18:18:38]

Committed patchset #4 manually as r235762 (presubmit successful).