chrome/common/extensions/docs/server2/render_servlet.py - Issue 65643009: Docserver: Attach intro metadata to the template itself, not to an object which

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/render_servlet.py

Issue 65643009: Docserver: Attach intro metadata to the template itself, not to an object which (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/intro_data_source_test.py ('k') | chrome/common/extensions/docs/server2/template_renderer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/render_servlet.py

diff --git a/chrome/common/extensions/docs/server2/render_servlet.py b/chrome/common/extensions/docs/server2/render_servlet.py

index a38eb6dee7569d660297e944b19a9cea16dc3421..efdec443e0cb35bdd0b5104fb266bc47c3931a80 100644

--- a/chrome/common/extensions/docs/server2/render_servlet.py

+++ b/chrome/common/extensions/docs/server2/render_servlet.py

@@ -10,6 +10,7 @@ import traceback

from urlparse import urlsplit

from data_source_registry import CreateDataSources

+from environment import IsPreviewServer

from file_system import FileNotFoundError

from redirector import Redirector

from servlet import Servlet, Response

@@ -47,6 +48,8 @@ class RenderServlet(Servlet):

try:

return self._GetSuccessResponse(path, server_instance)

except FileNotFoundError:

+ if IsPreviewServer():

+ logging.error(traceback.format_exc())

# Maybe it didn't find the file because its canonical location is

# somewhere else; this is distinct from "redirects", which are typically

# explicit. This is implicit.