Issue 656413003: Revert of Oilpan: move ScriptLoader to the heap.

Issue 656413003: Revert of Oilpan: move ScriptLoader to the heap. (Closed)

Created:
6 years, 2 months ago by dstockwell

Modified:
6 years, 2 months ago

Reviewers:
oilpan-reviews, haraken, sof

CC:
blink-reviews, ed+blinkwatch_opera.com, blink-reviews-html_chromium.org, sof, eae+blinkwatch, fs, kouhei+svg_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, krit, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of Oilpan: move ScriptLoader to the heap. (patchset #3 id:2 of https://codereview.chromium.org/660233002/) Reason for revert: Depends on https://codereview.chromium.org/656113002 which introduced memory leaks. Original issue's description: > Oilpan: move ScriptLoader to the heap. > > So as to be able to trace its PendingScript part object. > > R=haraken > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183909 TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183951

Patch Set 1 #

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -50 lines)			Patch
M	Source/core/dom/PendingScript.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/ScriptLoader.h	View	3 chunks	+16 lines, -15 lines	0 comments	Download
M	Source/core/dom/ScriptLoader.cpp	View	3 chunks	+2 lines, -9 lines	0 comments	Download
M	Source/core/dom/ScriptRunner.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	Source/core/dom/ScriptRunner.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLScriptElement.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	Source/core/html/HTMLScriptElement.cpp	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	Source/core/svg/SVGScriptElement.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGScriptElement.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dstockwell

Created Revert of Oilpan: move ScriptLoader to the heap.

6 years, 2 months ago (2014-10-19 23:16:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656413003/1

6 years, 2 months ago (2014-10-19 23:17:52 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 183951

6 years, 2 months ago (2014-10-19 23:18:34 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages