Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 656393002: [fsp] Pass proper data to Notify(). (Closed)

Created:
6 years, 2 months ago by mtomasz
Modified:
6 years, 2 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

[fsp] Pass proper data to Notify(). This patch passes proper data instead of fake one to Notify(). Also, child changes are now passed as a scoped_ptr and a reference to avoid unnecessary copies. Note, that end to end browser tests will come once notifications are wired to chrome.fileManagerPrivate. TEST=Tested manually. BUG=248427 Committed: https://crrev.com/a15683665c360d910e2204198993d060163b8058 Cr-Commit-Position: refs/heads/master@{#300062}

Patch Set 1 #

Messages

Total messages: 8 (2 generated)
mtomasz
@hirono: PTAL. Thanks!
6 years, 2 months ago (2014-10-17 02:03:55 UTC) #2
hirono
lgtm!
6 years, 2 months ago (2014-10-17 03:59:19 UTC) #3
mtomasz
On 2014/10/17 03:59:19, hirono wrote: > lgtm! Thanks!
6 years, 2 months ago (2014-10-17 04:09:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656393002/1
6 years, 2 months ago (2014-10-17 04:10:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 04:22:04 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 04:22:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a15683665c360d910e2204198993d060163b8058
Cr-Commit-Position: refs/heads/master@{#300062}

Powered by Google App Engine
This is Rietveld 408576698