Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3828)

Unified Diff: chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h

Issue 656393002: [fsp] Pass proper data to Notify(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h
diff --git a/chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h b/chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h
index cd3c9d57bb54a70bd62e3041192c9bd99c2eedc4..2e2541a00eed227ddedfbe125311b450911d74ad 100644
--- a/chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h
+++ b/chrome/browser/chromeos/file_system_provider/provided_file_system_observer.h
@@ -51,7 +51,8 @@ class ProvidedFileSystemObserver {
// Called when an observed entry is changed, including removals. |callback|
// *must* be called after the entry change is handled. Once all observers
// call the callback, the tag will be updated and OnObservedEntryTagUpdated
- // called.
+ // called. The reference to |child_changes| is valid at least as long as
+ // |callback|.
virtual void OnObservedEntryChanged(
const ProvidedFileSystemInfo& file_system_info,
const base::FilePath& observed_path,

Powered by Google App Engine
This is Rietveld 408576698