Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 656363002: Type conversion fixes, components/ edition. (Closed)

Created:
6 years, 2 months ago by Peter Kasting
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Type conversion fixes, components/ edition. This is mostly to fix MSVC warnings about possible value truncation. BUG=81439 TEST=none Committed: https://crrev.com/e232eca6b56b30a0e483cac8e4303d2e547db213 Cr-Commit-Position: refs/heads/master@{#300134}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -38 lines) Patch
M components/favicon_base/favicon_util.cc View 3 chunks +25 lines, -22 lines 1 comment Download
M components/favicon_base/select_favicon_frames.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M components/nacl/loader/nacl_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/autocomplete_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/precache/core/precache_database.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M components/storage_monitor/test_volume_mount_watcher_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/common/translate_metrics.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Kasting
https://codereview.chromium.org/656363002/diff/1/components/favicon_base/favicon_util.cc File components/favicon_base/favicon_util.cc (left): https://codereview.chromium.org/656363002/diff/1/components/favicon_base/favicon_util.cc#oldcode82 components/favicon_base/favicon_util.cc:82: // |desired_size_in_pixel| x |desired_size_in_pixel| by resampling the best Changing ...
6 years, 2 months ago (2014-10-16 22:36:53 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-17 12:03:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656363002/1
6 years, 2 months ago (2014-10-17 18:17:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 18:29:52 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 18:30:34 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e232eca6b56b30a0e483cac8e4303d2e547db213
Cr-Commit-Position: refs/heads/master@{#300134}

Powered by Google App Engine
This is Rietveld 408576698