Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Unified Diff: components/favicon_base/select_favicon_frames.cc

Issue 656363002: Type conversion fixes, components/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon_base/select_favicon_frames.cc
diff --git a/components/favicon_base/select_favicon_frames.cc b/components/favicon_base/select_favicon_frames.cc
index 8df5f8cde255478a4c02693716b09c839474177c..d53225d9c919287fc2eef814c909e7c4060fb6a0 100644
--- a/components/favicon_base/select_favicon_frames.cc
+++ b/components/favicon_base/select_favicon_frames.cc
@@ -41,8 +41,9 @@ SkBitmap SampleNearestNeighbor(const SkBitmap& contents, int desired_size) {
{
SkCanvas canvas(bitmap);
- SkRect dest(SkRect::MakeWH(desired_size, desired_size));
- canvas.drawBitmapRect(contents, NULL, dest);
+ canvas.drawBitmapRect(
+ contents, NULL,
+ SkRect::MakeFromIRect(SkIRect::MakeWH(desired_size, desired_size)));
}
return bitmap;
@@ -224,7 +225,8 @@ gfx::ImageSkia CreateFaviconImageSkia(
} else {
for (std::vector<float>::const_iterator iter = favicon_scales.begin();
iter != favicon_scales.end(); ++iter) {
- desired_sizes.push_back(ceil(desired_size_in_dip * (*iter)));
+ desired_sizes.push_back(
+ static_cast<int>(ceil(desired_size_in_dip * (*iter))));
}
}

Powered by Google App Engine
This is Rietveld 408576698