Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: tools/telemetry/telemetry/core/wpr_server.py

Issue 656303003: Telemetry: Move Web Page Replay to the platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update --use-live-sites tests to not use private browser property. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/webpagereplay.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/wpr_server.py
diff --git a/tools/telemetry/telemetry/core/wpr_server.py b/tools/telemetry/telemetry/core/wpr_server.py
index 08f8bad02b4110f77ffbc9afe399259bc7306539..5afcd0f2e6073a97ed43f02e91bb6ab7886a07cb 100644
--- a/tools/telemetry/telemetry/core/wpr_server.py
+++ b/tools/telemetry/telemetry/core/wpr_server.py
@@ -12,15 +12,14 @@ from telemetry.core import wpr_modes
class ReplayServer(object):
- def __init__(self, browser_backend, path, wpr_mode,
- make_javascript_deterministic):
- self._browser_backend = browser_backend
+ def __init__(self, browser_backend, archive_path, wpr_mode, netsim,
+ extra_wpr_args, make_javascript_deterministic):
self._forwarder = None
self._web_page_replay = None
- wpr_args = browser_backend.browser_options.extra_wpr_args
- if browser_backend.browser_options.netsim:
- wpr_args.append('--net=%s' % browser_backend.browser_options.netsim)
+ wpr_args = list(extra_wpr_args)
+ if netsim:
+ wpr_args.append('--net=%s' % netsim)
if wpr_mode == wpr_modes.WPR_APPEND:
wpr_args.append('--append')
elif wpr_mode == wpr_modes.WPR_RECORD:
@@ -33,7 +32,7 @@ class ReplayServer(object):
'--https_root_ca_cert_path=%s' % browser_backend.wpr_ca_cert_path,
])
self._web_page_replay = webpagereplay.ReplayServer(
- path, self._browser_backend.forwarder_factory.host_ip,
+ archive_path, browser_backend.forwarder_factory.host_ip,
browser_backend.wpr_port_pairs.http.local_port,
browser_backend.wpr_port_pairs.https.local_port,
(browser_backend.wpr_port_pairs.dns.local_port
« no previous file with comments | « tools/telemetry/telemetry/core/webpagereplay.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698