tools/telemetry/telemetry/core/webpagereplay.py - Issue 656303003: Telemetry: Move Web Page Replay to the platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/webpagereplay.py

Issue 656303003: Telemetry: Move Web Page Replay to the platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update --use-live-sites tests to not use private browser property. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/webpagereplay.py

diff --git a/tools/telemetry/telemetry/core/webpagereplay.py b/tools/telemetry/telemetry/core/webpagereplay.py

index ea1996e347d02f4417bf07abe6a735850f420b61..cebc6613c09bd5259835893cb60b04ea70f911a7 100644

--- a/tools/telemetry/telemetry/core/webpagereplay.py

+++ b/tools/telemetry/telemetry/core/webpagereplay.py

@@ -12,7 +12,6 @@ import subprocess

import sys

import urllib

-from telemetry.core import platform

from telemetry.core import util

_REPLAY_DIR = os.path.join(

@@ -191,8 +190,7 @@ class ReplayServer(object):

Raises:

ReplayNotStartedError: if Replay start-up fails.

"""

- is_posix = platform.GetHostPlatform().GetOSName() in ('linux', 'mac')

+ is_posix = sys.platform.startswith('linux') or sys.platform == 'darwin'

logging.debug('Starting Web-Page-Replay: %s', self._cmd_line)

with self._OpenLogFile() as log_fh:

self.replay_process = subprocess.Popen(